Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 18, 2024

Deprecate the Span.parentSpanId field on the interface and class.

This required only a couple of code replacements and a bunch of test adjustments. Also went ahead and changed the integration test event type in the tests I was modifying (#10240).

ref #10184

@Lms24 Lms24 self-assigned this Jan 18, 2024
@Lms24 Lms24 requested review from AbhiPrasad and mydea January 18, 2024 13:58
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.64 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.91 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.79 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.54 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.92 KB (+0.08% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.16 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (0%)
@sentry/browser - Webpack (gzipped) 22.51 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.22 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.84 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.7 KB (+0.06% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.59 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 98.57 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.52 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.74 KB (+0.06% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.33 KB (+0.04% 🔺)
@sentry/react - Webpack (gzipped) 22.55 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.92 KB (+0.04% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.03 KB (+0.05% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.14 KB (0%)

@Lms24 Lms24 force-pushed the lms/feat-core-deprecate-span-parentSpanId branch from 8fb0e98 to 49ae0f8 Compare January 18, 2024 14:36
@Lms24 Lms24 force-pushed the lms/feat-core-deprecate-span-parentSpanId branch from 49ae0f8 to 560fcdb Compare January 19, 2024 10:28
@Lms24 Lms24 merged commit d3fecc1 into develop Jan 19, 2024
@Lms24 Lms24 deleted the lms/feat-core-deprecate-span-parentSpanId branch January 19, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants