Skip to content

Commit 560fcdb

Browse files
committed
fix tests, migration doc
1 parent 0a0faa3 commit 560fcdb

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

MIGRATION.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@ In v8, the Span class is heavily reworked. The following properties & methods ar
193193
- `span.getTraceContext()`: Use `spanToTraceContext(span)` utility function instead.
194194
- `span.sampled`: Use `span.isRecording()` instead.
195195
- `span.spanId`: Use `span.spanContext().spanId` instead.
196+
- `span.parentSpanId`: Use `spanToJSON(span).parent_span_id` instead.
196197
- `span.traceId`: Use `span.spanContext().traceId` instead.
197198
- `span.name`: Use `spanToJSON(span).description` instead.
198199
- `span.description`: Use `spanToJSON(span).description` instead.

docs/v8-new-performance-apis.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ below to see which things used to exist, and how they can/should be mapped going
4646
| --------------------- | ---------------------------------------------------- |
4747
| `traceId` | `spanContext().traceId` |
4848
| `spanId` | `spanContext().spanId` |
49-
| `parentSpanId` | Unchanged |
49+
| `parentSpanId` | `spanToJSON(span).parent_span_id` |
5050
| `status` | use utility method TODO |
5151
| `sampled` | `spanIsSampled(span)` |
5252
| `startTimestamp` | `startTime` - note that this has a different format! |

packages/core/test/lib/scope.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,7 @@ describe('withActiveSpan()', () => {
544544
});
545545

546546
it('should create child spans when calling startSpan within the callback', done => {
547-
expect.assertions(1);
547+
expect.assertions(2);
548548
const inactiveSpan = startInactiveSpan({ name: 'inactive-span' });
549549

550550
withActiveSpan(inactiveSpan!, () => {

0 commit comments

Comments
 (0)