Skip to content

fix(node): Anr doesn't block exit #10064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2024
Merged

fix(node): Anr doesn't block exit #10064

merged 2 commits into from
Jan 4, 2024

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented Jan 4, 2024

Closes #10023

worker.on actually calls worker.ref() internally so worker.unref() needs calling after!

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Jan 4, 2024 •
edited
Loading

Gonna update this to latest develop to fix remix failures, want to get this out with the release.

@AbhiPrasad AbhiPrasad merged commit 33348ec into getsentry:develop Jan 4, 2024
@timfish timfish deleted the fix/node-anr-exit branch January 4, 2024 17:25
c298lee pushed a commit that referenced this pull request Jan 9, 2024
@timfish @c298lee
fix(node): Anr doesn't block exit (#10064)
8c6b72e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Script won't exit "naturally" with ANR active

2 participants

@timfish @AbhiPrasad