fix(node): Anr doesn't block exit (#10064)

Author: timfish

dev-packages/node-integration-tests/suites/anr/should-exit-forced.js

@@ -0,0 +1,19 @@
+const Sentry = require('@sentry/node');
+
+function configureSentry() {
+  Sentry.init({
+    dsn: 'https://[email protected]/1337',
+    release: '1.0',
+    debug: true,
+    autoSessionTracking: false,
+    integrations: [new Sentry.Integrations.Anr({ captureStackTrace: true })],
+  });
+}
+
+async function main() {
+  configureSentry();
+  await new Promise(resolve => setTimeout(resolve, 1000));
+  process.exit(0);
+}
+
+main();

dev-packages/node-integration-tests/suites/anr/should-exit.js

@@ -13,7 +13,6 @@ function configureSentry() {
 async function main() {
   configureSentry();
   await new Promise(resolve => setTimeout(resolve, 1000));
-  process.exit(0);
 }
 
 main();

dev-packages/node-integration-tests/suites/anr/test.ts

@@ -115,7 +115,7 @@ conditionalTest({ min: 16 })('should report ANR when event loop blocked', () =>
     });
   });
 
-  test('can exit', done => {
+  test('should exit', done => {
     const testScriptPath = path.resolve(__dirname, 'should-exit.js');
     let hasClosed = false;
 
@@ -129,6 +129,20 @@ conditionalTest({ min: 16 })('should report ANR when event loop blocked', () =>
     });
   });
 
+  test('should exit forced', done => {
+    const testScriptPath = path.resolve(__dirname, 'should-exit-forced.js');
+    let hasClosed = false;
+
+    setTimeout(() => {
+      expect(hasClosed).toBe(true);
+      done();
+    }, 5_000);
+
+    childProcess.exec(`node ${testScriptPath}`, { encoding: 'utf8' }, () => {
+      hasClosed = true;
+    });
+  });
+
   test('With session', done => {
     expect.assertions(9);
 

packages/node/src/integrations/anr/index.ts

@@ -122,8 +122,6 @@ async function _startWorker(client: NodeClient, _options: Partial<Options>): Pro
   const worker = new Worker(new URL(`data:application/javascript;base64,${base64WorkerScript}`), {
     workerData: options,
   });
-  // Ensure this thread can't block app exit
-  worker.unref();
 
   process.on('exit', () => {
     worker.terminate();
@@ -160,4 +158,7 @@ async function _startWorker(client: NodeClient, _options: Partial<Options>): Pro
     clearInterval(timer);
     log('ANR worker exit', code);
   });
+
+  // Ensure this thread can't block app exit
+  worker.unref();
 }