Skip to content

feat: Update Astro to v8.0.0-beta.6 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2024
Merged

feat: Update Astro to v8.0.0-beta.6 #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d815524
upgrade Sentry to v8
s1gr1d May 6, 2024
779ce60
feat(astro): Upgrade Sentry to v8
s1gr1d Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/astro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"dependencies": {
"@astrojs/check": "^0.5.10",
"@astrojs/node": "^8.2.5",
"@sentry/astro": "7.113.0",
"@sentry/astro": "8.9.2",
"astro": "^4.7.0",
"typescript": "^5.4.5"
}
Expand Down
33 changes: 11 additions & 22 deletions payload-files/astro/_test-param-error_1337--transaction.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"event_id": "[[ID1]]",
"sdk": {
"name": "sentry.javascript.astro",
"version": "7.113.0"
"version": "8.0.0-beta.6"
},
"sent_at": "[[ISODateString]]",
"trace": {
"environment": "qa",
"public_key": "[[publicKey]]",
"release": "d9b30b85f9c70e8a590b9932552161cf132eaffa",
"release": "9570e7fc5b7da6cd2a5395fe69d3bb14fe2551a9",
"sample_rate": "1",
"sampled": "true",
"trace_id": "[[ID2]]"
Expand All @@ -23,6 +23,7 @@
"contexts": {
"trace": {
"data": {
"hardwareConcurrency": "10",
"sentry.op": "pageload",
"sentry.origin": "auto.pageload.browser",
"sentry.sample_rate": 1,
Expand All @@ -31,11 +32,6 @@
"op": "pageload",
"origin": "auto.pageload.browser",
"span_id": "[[ID3]]",
"tags": {
"hardwareConcurrency": "10",
"lcp.element": "body > h1",
"lcp.size": "[[highNumber]]"
},
"trace_id": "[[ID2]]"
}
},
Expand All @@ -44,23 +40,19 @@
"measurements": {
"fcp": {
"unit": "millisecond",
"value": 164
},
"lcp": {
"unit": "millisecond",
"value": 164
"value": 144
},
"ttfb": {
"unit": "millisecond",
"value": 87
"value": 65
},
"ttfb.requestTime": {
"unit": "millisecond",
"value": 22
"value": 27
}
},
"platform": "javascript",
"release": "d9b30b85f9c70e8a590b9932552161cf132eaffa",
"release": "9570e7fc5b7da6cd2a5395fe69d3bb14fe2551a9",
"request": {
"headers": {
"Referer": "http://localhost:4321/",
Expand All @@ -72,7 +64,7 @@
"integrations": [
"InboundFilters",
"FunctionToString",
"TryCatch",
"BrowserApiErrors",
"Breadcrumbs",
"GlobalHandlers",
"LinkedErrors",
Expand All @@ -84,21 +76,18 @@
"packages": [
{
"name": "npm:@sentry/astro",
"version": "7.113.0"
"version": "8.0.0-beta.6"
},
{
"name": "npm:@sentry/browser",
"version": "7.113.0"
"version": "8.0.0-beta.6"
}
],
"version": "7.113.0"
"version": "8.0.0-beta.6"
},
"spans": [],
"start_timestamp": "[[timestamp]]",
"tags": {
"hardwareConcurrency": "10",
"lcp.element": "body > h1",
"lcp.size": "[[highNumber]]",
Comment on lines -99 to -101
Copy link
Member Author

@s1gr1d s1gr1d May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCP is missing

"runtime": "browser"
},
"timestamp": "[[timestamp]]",
Expand Down
75 changes: 50 additions & 25 deletions payload-files/astro/_test-param-error_[param]--transaction.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"event_id": "[[ID1]]",
"sdk": {
"name": "sentry.javascript.astro",
"version": "7.113.0"
"version": "8.0.0-beta.6"
},
"sent_at": "[[ISODateString]]",
"trace": {
"environment": "qa",
"public_key": "[[publicKey]]",
"release": "d9b30b85f9c70e8a590b9932552161cf132eaffa",
"release": "9570e7fc5b7da6cd2a5395fe69d3bb14fe2551a9",
"sample_rate": "1",
"sampled": "true",
"trace_id": "[[ID2]]",
Expand All @@ -25,8 +25,7 @@
{
"category": "http",
"data": {
"method": "GET",
"status_code": 500,
"http.method": "GET",
"url": "http://localhost:4321/api/test-param-error/1337"
},
"timestamp": "[[timestamp]]",
Expand Down Expand Up @@ -58,6 +57,16 @@
"name": "macOS",
"version": "14.2"
},
"otel": {
"resource": {
"service.name": "node",
"service.namespace": "sentry",
"service.version": "8.0.0-beta.6",
"telemetry.sdk.language": "nodejs",
"telemetry.sdk.name": "opentelemetry",
"telemetry.sdk.version": "1.23.0"
}
},
"runtime": {
"name": "node",
"version": "v20.11.1"
Expand All @@ -66,6 +75,7 @@
"data": {
"http.response.status_code": 200,
"method": "GET",
"otel.kind": "INTERNAL",
"sentry.op": "http.server",
"sentry.origin": "auto.http.astro",
"sentry.sample_rate": 1,
Expand All @@ -76,17 +86,19 @@
"origin": "auto.http.astro",
"span_id": "[[ID3]]",
"status": "ok",
"tags": {
"http.status_code": "200"
},
"trace_id": "[[ID2]]"
}
},
"environment": "qa",
"event_id": "[[ID1]]",
"modules": {},
"platform": "node",
"release": "d9b30b85f9c70e8a590b9932552161cf132eaffa",
"release": "9570e7fc5b7da6cd2a5395fe69d3bb14fe2551a9",
"request": {
"cookies": {},
"headers": {},
"method": "GET",
"url": "http://localhost:4321/test-param-error/1337"
Copy link
Member Author

@s1gr1d s1gr1d May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not parameterized

},
"sdk": {
"integrations": [
"InboundFilters",
Expand All @@ -95,60 +107,73 @@
"RequestData",
"Console",
"Http",
"Undici",
"NodeFetch",
"OnUncaughtException",
"OnUnhandledRejection",
"ContextLines",
"LocalVariables",
"LocalVariablesAsync",
"Context",
"Modules"
"Express",
"Fastify",
"Graphql",
"Mongo",
"Mongoose",
"Mysql",
"Mysql2",
"Redis",
"Postgres",
"Nest",
"Hapi",
"Koa",
"Connect"
],
"name": "sentry.javascript.astro",
"packages": [
{
"name": "npm:@sentry/astro",
"version": "7.113.0"
"version": "8.0.0-beta.6"
},
{
"name": "npm:@sentry/node",
"version": "7.113.0"
"version": "8.0.0-beta.6"
}
],
"version": "7.113.0"
"version": "8.0.0-beta.6"
},
"server_name": "D9M3PY4LQ7.local",
"spans": [
{
"data": {
"http.client": "fetch",
"http.method": "GET",
"http.response.status_code": 500,
"http.status_code": 500,
"http.target": "/api/test-param-error/1337",
"http.url": "http://localhost:4321/api/test-param-error/1337",
Comment on lines +151 to +152
Copy link
Member Author

@s1gr1d s1gr1d May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not parameterized

Copy link
Member

@mydea mydea May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, this is "only" outgoing fetch stuff!

"otel.kind": "CLIENT",
"sentry.op": "http.client",
"sentry.origin": "auto.http.node.undici"
"sentry.origin": "auto.http.otel.node_fetch",
"url": "http://localhost:4321/api/test-param-error/1337"
},
"description": "GET http://localhost:4321/api/test-param-error/1337",
"op": "http.client",
"origin": "auto.http.node.undici",
"origin": "auto.http.otel.node_fetch",
Copy link
Member Author

@s1gr1d s1gr1d May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Origin is different

Copy link
Member

@mydea mydea May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine too, to be expected :)

"parent_span_id": "[[ID3]]",
"span_id": "[[ID4]]",
"start_timestamp": "[[timestamp]]",
"status": "internal_error",
"tags": {
"http.status_code": "500"
},
"status": "unknown_error",
"timestamp": "[[timestamp]]",
"trace_id": "[[ID2]]"
}
],
"start_timestamp": "[[timestamp]]",
"tags": {
"http.status_code": "200",
"runtime": "node",
"transaction": "GET /test-param-error/[param]"
"runtime": "node"
},
"timestamp": "[[timestamp]]",
"transaction": "GET /test-param-error/[param]",
"transaction_info": {
"source": "custom"
"source": "route"
Copy link
Member Author

@s1gr1d s1gr1d May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different source

Copy link
Member

@mydea mydea May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems more correct than before 🤔 so all good :D

},
"type": "transaction"
}
Expand Down
33 changes: 11 additions & 22 deletions payload-files/astro/_test-param-success_1337--transaction.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"event_id": "[[ID1]]",
"sdk": {
"name": "sentry.javascript.astro",
"version": "7.113.0"
"version": "8.0.0-beta.6"
},
"sent_at": "[[ISODateString]]",
"trace": {
"environment": "qa",
"public_key": "[[publicKey]]",
"release": "d9b30b85f9c70e8a590b9932552161cf132eaffa",
"release": "9570e7fc5b7da6cd2a5395fe69d3bb14fe2551a9",
"sample_rate": "1",
"sampled": "true",
"trace_id": "[[ID2]]"
Expand All @@ -23,6 +23,7 @@
"contexts": {
"trace": {
"data": {
"hardwareConcurrency": "10",
"sentry.op": "pageload",
"sentry.origin": "auto.pageload.browser",
"sentry.sample_rate": 1,
Expand All @@ -31,11 +32,6 @@
"op": "pageload",
"origin": "auto.pageload.browser",
"span_id": "[[ID3]]",
"tags": {
"hardwareConcurrency": "10",
"lcp.element": "body > h1",
"lcp.size": "[[highNumber]]"
},
"trace_id": "[[ID2]]"
}
},
Expand All @@ -44,23 +40,19 @@
"measurements": {
"fcp": {
"unit": "millisecond",
"value": 184
},
"lcp": {
"unit": "millisecond",
"value": 186
"value": 135
},
"ttfb": {
"unit": "millisecond",
"value": 103
"value": 60
},
"ttfb.requestTime": {
"unit": "millisecond",
"value": 42
"value": 15
}
},
"platform": "javascript",
"release": "d9b30b85f9c70e8a590b9932552161cf132eaffa",
"release": "9570e7fc5b7da6cd2a5395fe69d3bb14fe2551a9",
"request": {
"headers": {
"Referer": "http://localhost:4321/",
Expand All @@ -72,7 +64,7 @@
"integrations": [
"InboundFilters",
"FunctionToString",
"TryCatch",
"BrowserApiErrors",
"Breadcrumbs",
"GlobalHandlers",
"LinkedErrors",
Expand All @@ -84,21 +76,18 @@
"packages": [
{
"name": "npm:@sentry/astro",
"version": "7.113.0"
"version": "8.0.0-beta.6"
},
{
"name": "npm:@sentry/browser",
"version": "7.113.0"
"version": "8.0.0-beta.6"
}
],
"version": "7.113.0"
"version": "8.0.0-beta.6"
},
"spans": [],
"start_timestamp": "[[timestamp]]",
"tags": {
"hardwareConcurrency": "10",
"lcp.element": "body > h1",
"lcp.size": "[[highNumber]]",
"runtime": "browser"
},
"timestamp": "[[timestamp]]",
Expand Down
Loading