feat: Update Astro to v8.0.0-beta.6 #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
commented
May 6, 2024
apps/astro/package.json
Outdated
| "@astrojs/check": "^0.5.10", | ||
| "@astrojs/node": "^8.2.5", | ||
| "@sentry/astro": "7.113.0", | ||
| "@sentry/astro": "8.0.0-beta.6", |
Member
Author
There was a problem hiding this comment.
That line was the only change in Astro 🙌🏻
s1gr1d
commented
May 6, 2024
Comment on lines
-99
to
-101
| "hardwareConcurrency": "10", | ||
| "lcp.element": "body > h1", | ||
| "lcp.size": "[[highNumber]]", |
s1gr1d
commented
May 6, 2024
| "cookies": {}, | ||
| "headers": {}, | ||
| "method": "GET", | ||
| "url": "http://localhost:4321/test-param-error/1337" |
s1gr1d
commented
May 6, 2024
Comment on lines
+151
to
+152
| "http.target": "/api/test-param-error/1337", | ||
| "http.url": "http://localhost:4321/api/test-param-error/1337", |
Member
There was a problem hiding this comment.
this is fine, this is "only" outgoing fetch stuff!
s1gr1d
commented
May 6, 2024
| "description": "GET http://localhost:4321/api/test-param-error/1337", | ||
| "op": "http.client", | ||
| "origin": "auto.http.node.undici", | ||
| "origin": "auto.http.otel.node_fetch", |
Member
There was a problem hiding this comment.
this is fine too, to be expected :)
s1gr1d
commented
May 6, 2024
| "transaction": "GET /test-param-error/[param]", | ||
| "transaction_info": { | ||
| "source": "custom" | ||
| "source": "route" |
Member
There was a problem hiding this comment.
seems more correct than before 🤔 so all good :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.