Skip to content

Conversation

@romtsn
Copy link
Member

@romtsn romtsn commented Jun 25, 2025

📜 Description

  • Do not redefine system resources coming from the @android namespace by not specifying the format property which makes the attribute a reference to the existing one.
  • Add user feedback widget to integrations list so we can track its adoption

💡 Motivation and Context

Closes #4516

💚 How did you test it?

Manually

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 403.52 ms 449.70 ms 46.18 ms
Size 1.58 MiB 2.09 MiB 519.08 KiB

Previous results on branch: rz/fix/feedback-widget-resources

Startup times

Revision Plain With Sentry Diff
ed619d9 386.45 ms 429.38 ms 42.93 ms

App size

Revision Plain With Sentry Diff
ed619d9 1.58 MiB 2.09 MiB 519.07 KiB

@romtsn romtsn enabled auto-merge (squash) June 25, 2025 14:53
@romtsn romtsn merged commit 8fde83a into main Jun 25, 2025
32 of 33 checks passed
@romtsn romtsn deleted the rz/fix/feedback-widget-resources branch June 25, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 8.14.0 breaks resources merging

3 participants