Version 8.14.0 breaks resources merging

[jschmid]

Integration

sentry-android

Build System

Gradle

AGP Version

8.13

Proguard

Enabled

Version

8.14.0

Steps to Reproduce

Declare attributes in your app. For example:

    <declare-styleable name="RoundedButton">
        <attr name="android:enabled" format="boolean" />
        <attr name="android:background" format="reference" />
    </declare-styleable>

Integrate Sentry 8.13.3 => Compiles
Upgrade to 8.14.0 => Compilation failures

Expected Result

Sentry does not clash with our app's code.

Actual Result

Output from ./gradlew assembleDebug

> Task :app:mergeDebugResources
/home/xxxx/.gradle/caches/8.13/transforms/09bcb44bfb4b47d04d160d0bc6cd78b0/transformed/sentry-android-core-8.14.0/res/values/values.xml:2:4: Duplicate value for resource 'android:attr/background' with config 'DEFAULT' and product ''. Resource was previously defined here: com.xxx-mergeDebugResources-154:/values/values.xml:17577: .

[jschmid]

Everything points to #4450

I don't however understand why AGP does not allow multiple <declare-styleable> to define a background.

[romtsn]

hi @jschmid thanks for reporting the issue! I think it stems from us defining the type of an attribute:

<attr name="android:background" format="reference" />

This is treated as a re-definition of the system attribute. We should drop format and just use

<attr name="android:background" />

to make it a reference. I will open a PR to fix that. I guess you should also not redefine the android: attributes in your resources and drop the format.

[jschmid]

Thanks for the quick fix. Yeah, we should not redefine this in our app. Some legacy code I'd rather not touch now :)