Skip to content

Conversation

@adinauer
Copy link
Member

📜 Description

Instead of only using SpringMvcTransactionNameProvider when spring-web is available, we now use both SpringServletTransactionNameProvider and SpringMvcTransactionNameProvider.

If SpringMvcTransactionNameProvider is able to resolve a transaction name from the route, it is used, otherwise we fallback to SpringServletTransactionNameProvider which provides the URL.

💡 Motivation and Context

Fixes #3277

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 378.74 ms 406.47 ms 27.72 ms
Size 1.58 MiB 2.21 MiB 647.14 KiB

Previous results on branch: fix/use-servlet-transaction-name-provider-as-fallback

Startup times

Revision Plain With Sentry Diff
7bf151c 400.98 ms 439.20 ms 38.22 ms
fc611c0 396.41 ms 482.76 ms 86.35 ms

App size

Revision Plain With Sentry Diff
7bf151c 1.58 MiB 2.21 MiB 646.59 KiB
fc611c0 1.58 MiB 2.21 MiB 647.13 KiB

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adinauer adinauer merged commit 64d302b into main Mar 18, 2025
35 checks passed
@adinauer adinauer deleted the fix/use-servlet-transaction-name-provider-as-fallback branch March 18, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentry-graphql does not send any GraphQL operations as transactions

4 participants