Sentry-graphql does not send any GraphQL operations as transactions

[Andrevmatias]

Integration

sentry-graphql

Java Version

17

Version

7.6.0

Steps to Reproduce

Using Spring Boot 2.7.8 and the spring boot sentry integration.

Instrumentation configuration:

@Configuration
class SentryConfiguration(
    val tracingDataBuilder: TracingDataBuilder
) {
    @Bean
    fun sentryTracingInstrumentation() = SentryInstrumentation(
        { span: ISpan, env: DataFetchingEnvironment, _: Any? ->
            tracingDataBuilder.createTags(env.operationDefinition.operation.toString()).forEach { (key, value) ->
                span.setTag(key, value)
            }
            span
        },
        SentrySpringSubscriptionHandler(),
        false
    )

    @Bean
    fun beforeSendTransactionCallback() = BeforeSendTransactionCallback { sentryTransaction, _ ->
        if (excludedRoutes.contains(sentryTransaction.transaction)) {
            null
        } else {
            sentryTransaction
        }
    }
}

application.properties

sentry.enabled=true
sentry.debug=true
sentry.dsn=[dsn]
sentry.release=@project.version@
sentry.environment=@spring.profiles.active@
sentry.traces-sample-rate=1.0

Expected Result

Sentry should send all GraphQL requests as transactions and spans for each query/mutation field.

Actual Result

No GraphQL transaction is being sent. Other transactions are working fine. The Debug info also does not show any GraphQL transaction.

Trying to figure out what was happening I investigated the SentryInstrumentation class and couldn't find where the transaction is supposed to be finished. I only found routines to finish the spans.

[adinauer]

Hello @Andrevmatias I just tested using our Spring Boot 2 sample and there's a transaction for the request which the GraphQL span is attached to. Maybe you can spot a difference to your setup by looking at our sample.

You can also attach a debugger to SentryInstrumentation line number 306 and check if there's an actual transaction there or if it's a NoOpTransaction.

[Andrevmatias]

Thanks @adinauer!

The only difference I noticed is that we use the graphql.kickstart.tools lib and don't specify the sentry.enable-tracing=true property (as it's deprecated).

The transaction value at line 306 is an instance of SentryTracer. It's finish method is never called. Isn't it the method responsible to send the event? So, these events are never sent to the sentry server, while "on demand" events are working fine.

[adinauer]

@Andrevmatias finish should be called by

sentry-java/sentry-spring/src/main/java/io/sentry/spring/tracing/SentryTracingFilter.java

Line 126 in 695d3a3

transaction.finish();

if you're using Spring Boot 2 WebMVC.

Can you add a breakpoint there and see what's happening?