Skip to content

Conversation

@adinauer
Copy link
Member

📜 Description

Remove startTimestamp ctor param and instead use SpanOptions.startTimestamp

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

adinauer and others added 30 commits March 27, 2024 16:30
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- POTEL 20 - Use `SpanOptions.startTimestamp` in `Span` constructor ([#3498](https://github.com/getsentry/sentry-java/pull/3498))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 1286bc7

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 382.74 ms 442.34 ms 59.60 ms
Size 1.70 MiB 2.28 MiB 596.92 KiB

Baseline results on branch: feat/potel-19-pr-review-feedback

Startup times

Revision Plain With Sentry Diff
0bb901c 422.57 ms 473.80 ms 51.22 ms
d6ef487 386.83 ms 468.12 ms 81.30 ms

App size

Revision Plain With Sentry Diff
0bb901c 1.70 MiB 2.28 MiB 596.95 KiB
d6ef487 1.70 MiB 2.28 MiB 596.98 KiB

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few commented lines starting from 475. Do we still need them for reference?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, kept it for reference, when implementing certain features that are still missing.

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a note about some commented code in SentryTracer.
Otherwise LGTM 👍

Base automatically changed from feat/potel-19-pr-review-feedback to 8.x.x June 24, 2024 12:18
@adinauer adinauer merged commit d90e0f9 into 8.x.x Jun 24, 2024
@adinauer adinauer deleted the feat/potel-20-start-timestamp-sentry-span branch June 24, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants