-
-
Notifications
You must be signed in to change notification settings - Fork 461
POTEL 20 - Use SpanOptions.startTimestamp in Span constructor
#3498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pes-merge-2-add-scopes
…ainScopes to rootScopes
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- POTEL 20 - Use `SpanOptions.startTimestamp` in `Span` constructor ([#3498](https://github.com/getsentry/sentry-java/pull/3498))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite a few commented lines starting from 475. Do we still need them for reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, kept it for reference, when implementing certain features that are still missing.
lbloder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a note about some commented code in SentryTracer.
Otherwise LGTM 👍
📜 Description
Remove
startTimestampctor param and instead useSpanOptions.startTimestamp💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps