POTEL 20 - Use SpanOptions.startTimestamp in Span constructor (#3498)

* replace hub with scopes

* Add Scopes

* Introduce `IScopes` interface.

* Replace `IHub` with `IScopes` in core

* Replace `IHub` with `IScopes` in android core

* Replace `IHub` with `IScopes` in android integrations

* Replace `IHub` with `IScopes` in apollo integrations

* Replace `IHub` with `IScopes` in okhttp integration

* Replace `IHub` with `IScopes` in graphql integration

* Replace `IHub` with `IScopes` in logging integrations

* Replace `IHub` with `IScopes` in more integrations

* Replace `IHub` with `IScopes` in OTel integration

* Replace `IHub` with `IScopes` in Spring 5 / Spring Boot 2 integrations

* Replace `IHub` with `IScopes` in Spring 6 / Spring Boot 3 integrations

* Replace `IHub` with `IScopes` in samples

* gitscopes -> github

* Replace ThreadLocal with ScopesStorage

* Move client and throwable to span map to scope

* Add global scope

* use global scope in Scopes

* Implement pushScope popScope and withScope for Scopes

* Add pushIsolationScope; add fork methods to ISCope

* Use separate scopes for current, isolation and global scope; rename mainScopes to rootScopes

* Allow controlling which scope configureScope uses

* Combine scopes

* Use new API for CRONS integrations

* Add lifecycle helper

* Change spring integrations to use new API

* Use new API in servlet integrations

* Use new API for kotlin coroutines and wrapers for Supplier/Callable

* Discussion TODOs

* Fix breadcrumb ordering

* Mark TODOS with [HSM]

* Add getGlobalScope and forkedRootScopes to IScopes

* Fix EventProcessor ordering on scopes

* Reuse code in Scopes

* No longer replace global scope

* Replace hub occurrences in comments, var names etc.

* Implement ScopesTest

* Implement CombinedScopeViewTest

* Fix combined contexts

* Use combined scopes for cross platform

* Changes according to reviews of previous PRs

* more

* even more

* isEnabled checks client instead of having a property on Scopes

* Use SentryOptions.empty

* Remove Hub

* Use OpenTelemetry for Performance and Scopes propagation

* Promote certain span attributes

* Use OTel in Sentry API

* Deduplicate SpanInfo extraction

* Forward Sentry API to Sentry through OTel

* Use OTel status for Sentry span API

* POTel Tracing

* fix root span detection (remote flag), and scope closing

* Inherit OTel span IDs when sending to sentry

* Fix tracing; parse incoming baggage; add baggage to outgoing

* Cleanup

* Move sampling logic to OTel Sampler

* Remove internal span attributes so they are not sent to Sentry

* Use transaction name

* remove obsolete comment

* Keep OTel and Sentry span name/op in sync

* more cleanup

* Make it possible to ignore span origins

* Reuse TracesSampler instance

* Catch exceptions thrown by integration.close

* Set NoOpSpanFactory as property default

* Use correct SentryOptions for SentryClient ctor

* PR review feedback

* more

* Use SpanOptions.startTimestamp in Span ctor

Author: adinauer

sentry-okhttp/src/test/java/io/sentry/okhttp/SentryOkHttpEventTest.kt

@@ -67,7 +67,6 @@ class SentryOkHttpEventTest {
                 TransactionContext("name", "op", TracesSamplingDecision(true)),
                 SentryTracer(TransactionContext("name", "op", TracesSamplingDecision(true)), scopes),
                 scopes,
-                null,
                 SpanOptions()
             )
 

sentry-opentelemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SentrySampler.java

@@ -44,6 +44,7 @@ public SamplingResult shouldSample(
       final @NotNull SpanKind spanKind,
       final @NotNull Attributes attributes,
       final @NotNull List<LinkData> parentLinks) {
+    // TODO [POTEL] use SamplingDecision.DROP sentry internal spans
     // note: parentLinks seems to usually be empty
     final @Nullable Span parentOtelSpan = Span.fromContextOrNull(parentContext);
     final @Nullable OtelSpanWrapper parentSentrySpan =
@@ -65,6 +66,7 @@ public SamplingResult shouldSample(
   private @NotNull SamplingResult handleRootOtelSpan(
       final @NotNull String traceId, final @NotNull Context parentContext) {
     if (!options.isTraceSampling()) {
+      // TODO [POTEL] should this return RECORD_ONLY to allow tracing without performance
       return SamplingResult.create(SamplingDecision.DROP);
     }
     @Nullable Baggage baggage = null;

sentry/api/sentry.api

@@ -3104,7 +3104,7 @@ public final class io/sentry/ShutdownHookIntegration : io/sentry/Integration, ja
 }
 
 public final class io/sentry/Span : io/sentry/ISpan {
-	public fun <init> (Lio/sentry/TransactionContext;Lio/sentry/SentryTracer;Lio/sentry/IScopes;Lio/sentry/SentryDate;Lio/sentry/SpanOptions;)V
+	public fun <init> (Lio/sentry/TransactionContext;Lio/sentry/SentryTracer;Lio/sentry/IScopes;Lio/sentry/SpanOptions;)V
 	public fun finish ()V
 	public fun finish (Lio/sentry/SpanStatus;)V
 	public fun finish (Lio/sentry/SpanStatus;Lio/sentry/SentryDate;)V

sentry/src/main/java/io/sentry/SentryTracer.java

@@ -71,8 +71,7 @@ public SentryTracer(
     Objects.requireNonNull(context, "context is required");
     Objects.requireNonNull(scopes, "scopes are required");
 
-    this.root =
-        new Span(context, this, scopes, transactionOptions.getStartTimestamp(), transactionOptions);
+    this.root = new Span(context, this, scopes, transactionOptions);
 
     this.name = context.getName();
     this.instrumenter = context.getInstrumenter();

sentry/src/main/java/io/sentry/Span.java

@@ -79,13 +79,13 @@ public Span(
       final @NotNull TransactionContext context,
       final @NotNull SentryTracer sentryTracer,
       final @NotNull IScopes scopes,
-      final @Nullable SentryDate startTimestamp,
       final @NotNull SpanOptions options) {
     this.context = Objects.requireNonNull(context, "context is required");
     this.context.setOrigin(options.getOrigin());
     this.transaction = Objects.requireNonNull(sentryTracer, "sentryTracer is required");
     this.scopes = Objects.requireNonNull(scopes, "scopes are required");
     this.spanFinishedCallback = null;
+    final @Nullable SentryDate startTimestamp = options.getStartTimestamp();
     if (startTimestamp != null) {
       this.startTimestamp = startTimestamp;
     } else {
@@ -311,11 +311,6 @@ public boolean isFinished() {
   //    return new SentryId(UUID.nameUUIDFromBytes(getSpanId().toString().getBytes()));
   //  }
 
-  @Override
-  public @NotNull SentryId getEventId() {
-    return new SentryId(getSpanId().toString());
-  }
-
   @Override
   public void setThrowable(final @Nullable Throwable throwable) {
     this.throwable = throwable;

sentry/src/main/java/io/sentry/SpanOptions.java

@@ -13,7 +13,6 @@ public class SpanOptions {
   /** The start timestamp of the transaction */
   private @Nullable SentryDate startTimestamp = null;
 
-  // TODO [POTEL] this should also work for non OTel spans
   /**
    * Gets the startTimestamp
    *

sentry/src/test/java/io/sentry/protocol/SentrySpanTest.kt

@@ -20,8 +20,7 @@ class SentrySpanTest {
             TransactionContext("name", "op"),
             mock<SentryTracer>(),
             mock<IScopes>(),
-            SentryLongDate(1000000),
-            SpanOptions()
+            SpanOptions().also { it.startTimestamp = SentryLongDate(1000000) }
         )
 
         val sentrySpan = SentrySpan(span)

sentry/src/test/java/io/sentry/util/TracingUtilsTest.kt

@@ -41,7 +41,6 @@ class TracingUtilsTest {
                 TransactionContext("name", "op", TracesSamplingDecision(true)),
                 SentryTracer(TransactionContext("name", "op", TracesSamplingDecision(true)), scopes),
                 scopes,
-                null,
                 SpanOptions()
             )
         }