Skip to content

Spotlight fixes for Backend #3176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Spotlight fixes for Backend #3176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import io.sentry.cache.PersistingScopeObserver;
import io.sentry.compose.gestures.ComposeGestureTargetLocator;
import io.sentry.compose.viewhierarchy.ComposeViewHierarchyExporter;
import io.sentry.internal.SpotlightIntegration;
import io.sentry.internal.gestures.GestureTargetLocator;
import io.sentry.internal.viewhierarchy.ViewHierarchyExporter;
import io.sentry.transport.NoOpEnvelopeCache;
Expand Down Expand Up @@ -286,7 +285,7 @@ static void installDefaultIntegrations(
new NetworkBreadcrumbsIntegration(context, buildInfoProvider, options.getLogger()));
options.addIntegration(new TempSensorBreadcrumbsIntegration(context));
options.addIntegration(new PhoneStateBreadcrumbsIntegration(context));
options.addIntegration(new SpotlightIntegration());
// options.addIntegration(new SpotlightIntegration());
}

/**
Expand Down
2 changes: 2 additions & 0 deletions sentry-samples/sentry-samples-spring-boot-jakarta/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ sentry.ignored-checkins=ignored_monitor_slug_1,ignored_monitor_slug_2
sentry.debug=true
sentry.graphql.ignored-error-types=SOME_ERROR,ANOTHER_ERROR
sentry.enable-backpressure-handling=true
sentry.spotlight-connection-url=http://localhost:8969/stream
sentry.enablePrettySerializationOutput=false
in-app-includes="io.sentry.samples"

# Uncomment and set to true to enable aot compatibility
Expand Down
2 changes: 2 additions & 0 deletions sentry/src/main/java/io/sentry/SentryOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import io.sentry.clientreport.ClientReportRecorder;
import io.sentry.clientreport.IClientReportRecorder;
import io.sentry.clientreport.NoOpClientReportRecorder;
import io.sentry.internal.SpotlightIntegration;
import io.sentry.internal.debugmeta.IDebugMetaLoader;
import io.sentry.internal.debugmeta.NoOpDebugMetaLoader;
import io.sentry.internal.gestures.GestureTargetLocator;
Expand Down Expand Up @@ -2420,6 +2421,7 @@ private SentryOptions(final boolean empty) {
integrations.add(new UncaughtExceptionHandlerIntegration());

integrations.add(new ShutdownHookIntegration());
integrations.add(new SpotlightIntegration());

eventProcessors.add(new MainEventProcessor(this));
eventProcessors.add(new DuplicateEventDetectionEventProcessor(this));
Expand Down
3 changes: 3 additions & 0 deletions sentry/src/main/java/io/sentry/internal/SpotlightIntegration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ private void sendEnvelope(final @NotNull SentryEnvelope envelope) {

final @NotNull HttpURLConnection connection =
(HttpURLConnection) URI.create(url).toURL().openConnection();

connection.setReadTimeout(1000);
connection.setConnectTimeout(1000);
connection.setRequestMethod("POST");
connection.setDoOutput(true);

Expand Down