Skip to content

Conversation

@adinauer
Copy link
Member

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Spotlight fixes for Backend ([#3176](https://github.com/getsentry/sentry-java/pull/3176))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 50bc482

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 367.27 ms 435.10 ms 67.84 ms
Size 1.70 MiB 2.27 MiB 584.42 KiB

Baseline results on branch: feat/spotlight

Startup times

Revision Plain With Sentry Diff
ac77a10 380.06 ms 411.46 ms 31.40 ms
13edfa9 388.96 ms 461.32 ms 72.36 ms

App size

Revision Plain With Sentry Diff
ac77a10 1.70 MiB 2.27 MiB 584.47 KiB
13edfa9 1.70 MiB 2.27 MiB 585.59 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge this before I do any improvements on the feat/spotlight branch.

@markushi markushi marked this pull request as ready for review January 31, 2024 12:01
@markushi markushi merged commit 9972a7a into feat/spotlight Jan 31, 2024
@markushi markushi deleted the feat/spotlight-backend branch January 31, 2024 12:01
markushi added a commit that referenced this pull request Feb 20, 2024
* initial spotlight integration

* Format code

* Add options.getSpotlightConnectionUrl, move Spotlight integration to sentry core

* Fix formatting, api spec

* Spotlight fixes for Backend (#3176)

* Address PR feedback, add tests

* Format code

* Cleanup PR

* Update changelog

* Update sentry-samples/sentry-samples-android/src/main/AndroidManifest.xml

Co-authored-by: Roman Zavarnitsyn <[email protected]>

* Fix typos

* Address PR feedback

* Simplify beforeEnvelopeCallback

* Fix test

* Fix log argument order

---------

Co-authored-by: Sentry Github Bot <[email protected]>
Co-authored-by: Alexander Dinauer <[email protected]>
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants