Skip to content

feat(express): Add option of passing router to tracing integration #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2020
Merged

feat(express): Add option of passing router to tracing integration #2740

merged 2 commits into from
Dec 2, 2020

Conversation

@lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Dec 2, 2020 •
edited
Loading

As of getsentry/sentry-javascript#3078 the integration can also take a router instead of an app.

@vercel
Copy link

vercel bot commented Dec 2, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/hdcb56saj/sentry.dev
✅ Preview: https://sentry-docs-git-kmclb-pass-router-to-express-tracing.sentry.dev

lobsterkatie
lobsterkatie commented Dec 2, 2020
View reviewed changes
@kamilogorek kamilogorek self-requested a review December 2, 2020 20:32
@lobsterkatie lobsterkatie changed the title fix(express): Pass router to tracing integration rather than app feat(express): Add option of passing router to tracing integration Dec 2, 2020
@lobsterkatie lobsterkatie merged commit 287e92f into master Dec 2, 2020
@lobsterkatie lobsterkatie deleted the kmclb-pass-router-to-express-tracing branch December 2, 2020 20:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kamilogorek kamilogorek kamilogorek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lobsterkatie @kamilogorek