Skip to content

feat(express): Add option of passing router to tracing integration #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2020
Merged

feat(express): Add option of passing router to tracing integration #2740

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb1d083
pass router to integration rather than app
lobsterkatie Dec 2, 2020
a2338c7
fix the fix
lobsterkatie Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/platforms/node/guides/express/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,12 @@ Sentry.init({
// enable HTTP calls tracing
new Sentry.Integrations.Http({ tracing: true }),
// enable Express.js middleware tracing
new Tracing.Integrations.Express({ app }),
new Tracing.Integrations.Express({
// to trace all requests to the default router
app,
// alternatively, you can specify the routes you want to trace:
// router: someRouter,
}),
],

// We recommend adjusting this value in production, or using tracesSampler
Expand Down