Performance for Serverless on Python #2389

ajjindal · 2020-09-29T18:44:27Z

Supports Tracing
Captures function payload with the send-default-pii

vercel · 2020-09-29T18:44:31Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/4n6mometq/sentry.dev
✅ Preview: https://sentry-docs-git-feat-serverlesstransactionpython.sentry.dev

PeloWriter

LGTM

PeloWriter · 2020-09-29T19:13:16Z

src/platforms/python/guides/aws-lambda/index.mdx


+<Alert level="info" title="Note"><markdown>
+
+If you are using another web framework inside of AWS Lambda, the framework might catch those exceptions before we get to see them. Make sure to enable the framework specific integration as well, if one exists. See [_Integrations_](/platforms/python/#integrations) for more information.


Suggestion to clarify:

Suggested change

If you are using another web framework inside of AWS Lambda, the framework might catch those exceptions before we get to see them. Make sure to enable the framework specific integration as well, if one exists. See [_Integrations_](/platforms/python/#integrations) for more information.

If you are using another web framework inside of AWS Lambda, the framework might catch those exceptions before they are sent to Sentry. As a result, we recommend enabling the framework-specific integration as well, if one exists. See [_Integrations_](/platforms/python/#integrations) for more information.

src/platforms/python/guides/aws-lambda/index.mdx

PeloWriter · 2020-09-29T20:19:28Z

src/platforms/python/guides/aws-lambda/index.mdx


- Automatically report all exceptions from your Lambda Functions
+- Automatically report all exceptions and transactions from your Lambda Functions
+- You can control transactions sample rate using `traces_sample_rate`. You can learn more about transactions in [Distributed Tracing](/performance-monitoring/distributed-tracing/#traces-transactions-and-spans)


Note - the content for this setting is forthcoming in PR 2376.

ok let's not merge this PR before that one then. It seems that even with the current version of #2376 this will 404, so we'll have to re-review.

I took in the latest and the link still looks valid. @PeloWriter do you want me to update anything specific?

This link may be more helpful. So perhaps edit to:

You can control the the representative sample of transactions you send to Sentry by filtering transaction events

src/platforms/python/guides/gcp-functions/index.mdx

Co-authored-by: Fiona <[email protected]>

src/platforms/python/guides/aws-lambda/index.mdx

src/platforms/python/guides/gcp-functions/index.mdx

untitaker · 2020-09-30T06:02:48Z

src/platforms/python/guides/aws-lambda/index.mdx


- Automatically report all exceptions from your Lambda Functions
+- Automatically report all exceptions and transactions from your Lambda Functions
+- You can control transactions sample rate using `traces_sample_rate`. You can learn more about transactions in [Distributed Tracing](/performance-monitoring/distributed-tracing/#traces-transactions-and-spans)


ok let's not merge this PR before that one then. It seems that even with the current version of #2376 this will 404, so we'll have to re-review.

This reverts commit a3a507c.

Docs has many broken/dead fragment URLs because an anchored section of a page moved or was renamed.

…also centering logo on mobile. (#2187)

) * fix(urls): Use relative URLs instead of linking to docs.sentry.io * Revert relative URL change to api docs link * Fix grouping & fingerprinting link * Fix broken url on log4net docs

Co-authored-by: Fiona <[email protected]> Co-authored-by: Bruno Garcia <[email protected]> Co-authored-by: Manoel Aranda Neto <[email protected]>

Co-authored-by: Fiona <[email protected]>

- Expose dropdown for Product navigation - Move all product pages into /product/ - Re-order sidebar to push relevant (vs marketing/discovery) docs to the top

…ocs (#2376) Also a bunch of reorganization, and reworking of some (but not all) of the JS performance docs.

untitaker · 2020-10-01T09:18:45Z

@ajjindal the rebase is messed up, this PR now contains too many unrelated changes to be reviewable

ajjindal · 2020-10-01T18:12:05Z

Creating a different PR

EoF fix

bff0f62

ajjindal requested review from PeloWriter and untitaker September 29, 2020 18:44

PeloWriter approved these changes Sep 29, 2020

View reviewed changes

Update src/platforms/python/guides/aws-lambda/index.mdx

c0cbe1e

Co-authored-by: Fiona <[email protected]>

vercel bot temporarily deployed to Preview September 29, 2020 22:15 Inactive

Update src/platforms/python/guides/gcp-functions/index.mdx

9a9c3d9

Co-authored-by: Fiona <[email protected]>

vercel bot deployed to Preview September 29, 2020 22:15 View deployment

untitaker requested changes Sep 30, 2020

View reviewed changes

dcramer and others added 11 commits September 30, 2020 13:20

feat: Simplify Laravel instructions (#2388)

53516e0

feat: Switch to fixed navs with scrolling (#2387)

120569f

Revert "feat: Switch to fixed navs with scrolling (#2387)"

84b8b09

This reverts commit a3a507c.

updated links to route correctly (#2390)

90ce360

Docs has many broken/dead fragment URLs because an anchored section of a page moved or was renamed.

bumping hero up b/c of what I think is aliasing cuasing weird space, …

e829624

…also centering logo on mobile. (#2187)

fix(urls): Use relative URLs instead of linking to docs.sentry.io (#2382

14db801

) * fix(urls): Use relative URLs instead of linking to docs.sentry.io * Revert relative URL change to api docs link * Fix grouping & fingerprinting link * Fix broken url on log4net docs

fixed broken anchor tags (#2393)

bc87873

Update Java SDK docs to 3.0 (#2239)

7c36085

Co-authored-by: Fiona <[email protected]> Co-authored-by: Bruno Garcia <[email protected]> Co-authored-by: Manoel Aranda Neto <[email protected]>

Android: Current migration on top (#2396)

1ae53c7

relay: Next iteration of refactoring (#2365)

ab4c50b

version update

78c2e86

ajjindal requested review from a team and bruno-garcia as code owners September 30, 2020 20:21

vercel bot deployed to Preview September 30, 2020 20:21 View deployment

dcramer and others added 6 commits September 30, 2020 16:02

feat: Add example of how to sample rrweb (#2398)

0d6f5b0

Co-authored-by: Fiona <[email protected]>

feat: Improve Product Guides structure (#2399)

c5f52c6

- Expose dropdown for Product navigation - Move all product pages into /product/ - Re-order sidebar to push relevant (vs marketing/discovery) docs to the top

feat(performance): Add tracesSampleRate and tracesSampler to JS d…

ec8d6fe

…ocs (#2376) Also a bunch of reorganization, and reworking of some (but not all) of the JS performance docs.

fix: Language

5056fae

feat(api-docs): Remove old unused API docs files (#2400)

de38d62

version fix for GCP

3eafa3c

ajjindal requested a review from a team as a code owner September 30, 2020 23:03

vercel bot deployed to Preview September 30, 2020 23:03 View deployment

ajjindal closed this Oct 1, 2020

ajjindal deleted the feat/serverlessTransactionPython branch October 1, 2020 18:12

github-actions bot locked and limited conversation to collaborators Dec 16, 2020


		<Alert level="info" title="Note"><markdown>

		If you are using another web framework inside of AWS Lambda, the framework might catch those exceptions before we get to see them. Make sure to enable the framework specific integration as well, if one exists. See [_Integrations_](/platforms/python/#integrations) for more information.

Uh oh!

Performance for Serverless on Python #2389

Performance for Serverless on Python #2389

Uh oh!

Conversation

ajjindal commented Sep 29, 2020

Uh oh!

vercel bot commented Sep 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PeloWriter left a comment

Choose a reason for hiding this comment

Uh oh!

PeloWriter Sep 29, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PeloWriter Sep 29, 2020

Choose a reason for hiding this comment

Uh oh!

untitaker Sep 30, 2020

Choose a reason for hiding this comment

Uh oh!

ajjindal Sep 30, 2020

Choose a reason for hiding this comment

Uh oh!

PeloWriter Sep 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

untitaker Sep 30, 2020

Choose a reason for hiding this comment

Uh oh!

untitaker commented Oct 1, 2020

Uh oh!

ajjindal commented Oct 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

vercel bot commented Sep 29, 2020 •

edited

Loading

PeloWriter Sep 30, 2020 •

edited

Loading