Skip to content

Update Java SDK docs to 3.0 #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Sep 30, 2020
Merged

Update Java SDK docs to 3.0 #2239

merged 37 commits into from
Sep 30, 2020

Conversation

@maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Sep 10, 2020 •
edited
Loading

Documentation and guides for Java SDK 3.0

@vercel vercel bot temporarily deployed to Preview September 10, 2020 09:43 Inactive
@vercel
Copy link

vercel bot commented Sep 10, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/6rcol1kr8/sentry.dev
✅ Preview: https://sentry-docs-git-fork-maciejwalkowiak-sentry-java-30.sentry.dev

@vercel vercel bot temporarily deployed to Preview September 15, 2020 13:16 Inactive
@bruno-garcia
Copy link
Member

bruno-garcia commented Sep 30, 2020

Maybe worth hidding the generic breadcrumbs doc too: https://sentry-docs-git-fork-maciejwalkowiak-sentry-java-30.sentry.dev/platforms/java/enriching-events/breadcrumbs/

Since Java has its own. Right now 2 breadcrumbs items show on the list

bruno-garcia
bruno-garcia approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some improvements.
But it LGTM.

We can merge, release the SDK and iterate improving things.

@vercel vercel bot temporarily deployed to Preview September 30, 2020 12:57 Inactive
@vercel vercel bot temporarily deployed to Preview September 30, 2020 12:59 Inactive
@vercel vercel bot temporarily deployed to Preview September 30, 2020 13:00 Inactive
@maciejwalkowiak
Copy link
Contributor Author

maciejwalkowiak commented Sep 30, 2020

The problem with "Legacy" docs placement still remains. Since it's added to "Common" section, each guide has now a legacy section and you can end up on the site like Home > Platforms > Java > Spring Boot > Legacy SDK (1.7) > log4j 2.x

image

marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
src/includes/configuration/config-intro/java.mdx Outdated
```

```kotlin {tabTitle:Kotlin}
import io.sentry.SentryOptions.BeforeBreadcrumbCallback
Copy link
Contributor

@marandaneto marandaneto Sep 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this? its not using it

Copy link
Contributor Author

@maciejwalkowiak maciejwalkowiak Sep 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
src/platforms/java/common/legacy/configuration/index.mdx
Option names in the DSN exactly match the examples given below. For example, to enable sampling if you are setting your DSN via the environment:

```bash
SENTRY_DSN={DSN}/1?sample.rate=0.75 java -jar app.jar
Copy link
Contributor

@marandaneto marandaneto Sep 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SENTRY_DSN={DSN}/1?sample.rate=0.75 java -jar app.jar
SENTRY_DSN=___PUBLIC_DSN___/1?sample.rate=0.75 java -jar app.jar

marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
marandaneto
marandaneto reviewed Sep 30, 2020
View reviewed changes
@maciejwalkowiak @marandaneto
Apply suggestions from code review
60ef121 
Co-authored-by: Manoel Aranda Neto <[email protected]>
@vercel vercel bot temporarily deployed to Preview September 30, 2020 14:52 Inactive
@bruno-garcia
Copy link
Member

bruno-garcia commented Sep 30, 2020

Let's merge and iterate over this?!

@bruno-garcia bruno-garcia merged commit 6685fbf into getsentry:master Sep 30, 2020
ajjindal pushed a commit that referenced this pull request Sep 30, 2020
@maciejwalkowiak @PeloWriter
@bruno-garcia @marandaneto
Update Java SDK docs to 3.0 (#2239)
7c36085 
Co-authored-by: Fiona <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>
NisanthanNanthakumar pushed a commit that referenced this pull request Oct 1, 2020
@maciejwalkowiak @PeloWriter
@bruno-garcia @marandaneto
Update Java SDK docs to 3.0 (#2239)
f785c6b 
Co-authored-by: Fiona <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

+2 more reviewers

@marandaneto marandaneto marandaneto left review comments

@PeloWriter PeloWriter PeloWriter left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maciejwalkowiak @bruno-garcia @marandaneto @PeloWriter