Skip to content

Conversation

sergical
Copy link
Member

DESCRIBE YOUR PR

Makes onboarding buttons sticky only from lg and up - currently taking up 1/3 of a screen on most mobile devices

Before After
CleanShot 2025-08-21 at 10 58 34 CleanShot 2025-08-21 at 10 58 51

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Aug 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Aug 29, 2025 3:12pm
sentry-docs Ready Ready Preview Comment Aug 29, 2025 3:12pm

Copy link

codecov bot commented Aug 21, 2025

Bundle Report

Changes will increase total bundle size by 212 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.9MB 24 bytes (0.0%) ⬆️
sentry-docs-server-cjs 12.52MB 188 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/css/*.css 28 bytes 745.99kB 0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/chunks/app/[[...path]]/page-*.js 2 bytes 88.01kB 0.0%
static/AL5xqw6PLVdw3MRe2nkzv/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/AL5xqw6PLVdw3MRe2nkzv/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/kQmAovY2Kgyk05YK3eAtq/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/kQmAovY2Kgyk05YK3eAtq/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/app/[[...path]]/page-*.js:

  • ./src/components/onboarding/index.tsx → Total Size: 15.83kB
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 65 bytes 777.06kB 0.01%
../app/platform-redirect/page.js.nft.json 65 bytes 776.98kB 0.01%
../app/sitemap.xml/route.js.nft.json 65 bytes 774.45kB 0.01%
../app/[[...path]]/page.js 2 bytes 608.8kB 0.0%

Files in ../app/[[...path]]/page.js:

  • ./src/components/onboarding/index.tsx → Total Size: 14.96kB

  • ./src/components/onboarding/index.tsx → Total Size: 1.79kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 2 bytes 3.17MB 0.0%

Copy link
Member

@nikolovlazar nikolovlazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense

@sergical sergical merged commit ece1282 into master Aug 29, 2025
15 checks passed
@sergical sergical deleted the sergiydybskiy/remove-sticky-from-onboarding-options-on-mobile branch August 29, 2025 16:01
codyde added a commit that referenced this pull request Aug 30, 2025
* 'master' of https://github.com/getsentry/sentry-docs:
  Layout updates; widening content div, centering and responsiveness, scrollbar update (#14766)
  Document default sdk logging attributes (#14353)
  Bump API schema to b8165143 (#14764)
  fix(OnboardingOptionButtons) Remove sticky css on mobile (#14690)
  Unreal Engine: Add migration guide (#14186)
  docs(ai): Update AI agent integrations list (#14769)
  fix: Order versioned docs select items by recency (#14768)
  ref(python): Update wording regarding async init (#14631)
  docs(aws-integration): Remove alert that ESM is not supported (#14756)
  fix(feedback): Update docs with SwiftUI notes (#14227)
  chore(docs): Remove explicit openai agents integration registration (#14718)
  Update list of states subject to tax on /pricing (#14763)
  ref(replay): Refactor pages inside the Product Walkthrough > Replay area (#14712)
  docs(replay): Move FAQ Replay for Android questions into dedicated troubleshooting page (#14709)
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants