Skip to content

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Aug 12, 2025

init()-ing in an async function is not always possible (e.g. in an async web framework like FastAPI) and also not always necessary.

Direct link to preview: https://sentry-docs-git-ivana-pythonasync-init.sentry.dev/platforms/python/

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Preview Comment Aug 13, 2025 10:25pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored Aug 13, 2025 10:25pm

Copy link

codecov bot commented Aug 13, 2025

Bundle Report

Changes will decrease total bundle size by 1.11MB (-4.87%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.9MB 81 bytes (0.0%) ⬆️
sentry-docs-server-cjs 11.32MB -1.11MB (-8.89%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/chunks/8423-*.js 87 bytes 285.0kB 0.03%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/cA_zn-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/cA_zn-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/G1SmE1W6PEf_ChFc4HEvP/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/G1SmE1W6PEf_ChFc4HEvP/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -33.51kB 1.74MB -1.89%
../instrumentation.js -33.8kB 1.07MB -3.07%
9523.js -33.51kB 1.04MB -3.11%
../app/[[...path]]/page.js 87 bytes 604.28kB 0.01%
../app/[[...path]]/page.js.nft.json -334.52kB 413.54kB -44.72%
../app/platform-redirect/page.js.nft.json -334.52kB 413.45kB -44.72%
../app/sitemap.xml/route.js.nft.json -334.52kB 410.93kB -44.87%
7153.js (New) 29.25kB 29.25kB 100.0% 🚀
../app/api/ip-ranges/route.js -300 bytes 5.79kB -4.92%
../app/robots.txt/route.js -300 bytes 5.02kB -5.64%
2311.js (Deleted) -29.86kB 0 bytes -100.0% 🗑️

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 87 bytes 3.16MB 0.0%
/ -600 bytes 2.62MB -0.02%

@sentrivana sentrivana requested review from a team August 14, 2025 09:40
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤙

@sentrivana sentrivana merged commit 6193409 into master Aug 29, 2025
13 checks passed
@sentrivana sentrivana deleted the ivana/python/async-init branch August 29, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants