Adds a note that source maps are not uploaded for debug mode in React Native / Expo #11478
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
|
I think we should include the information also on the main source maps page. Maybe by adding a section similar to disabling the auto upload. And add explanation why it's not needed in Debug mode. As the symbolication is done by the Metro dev server. |
|
|
||
| - `dist` is the default output directory of `eas update`. | ||
| - Uploaded source maps have no associated releases. This is expected as updates can apply to multiple releases. | ||
| - Uploading of source maps for debug or simulator builds is disabled. |
There was a problem hiding this comment.
These are notes for EAS Updates, meaning for situation when a user creates a JS bundle to distribute as ota update.
This note is relevant for the previous section [Automatic Upload for Release](https://docs.sentry.io/platforms/react-native/sourcemaps/uploading/expo/#automatic-upload-for-release)
I would also include one sentence why, we do not auto upload for Debug.
There was a problem hiding this comment.
Good catch @krystofwoldrich 🙇 I've moved the note to the correct section adding a short sentence for the why with 6d154f7.
I think we should include the information also on the main source maps page.
Also added a separate a bit more extended section on the main source maps page with e339fd8
There was a problem hiding this comment.
Thank you. I suggest removing the sim builds as release for sim will upload the source maps.
I also added @lizokm to review the docs style.
There was a problem hiding this comment.
Thank you @krystofwoldrich! Makes sense. I've committed your suggestions 🙇
Co-authored-by: Krystof Woldrich <[email protected]>
Co-authored-by: Krystof Woldrich <[email protected]>
lizokm
left a comment
lizokm
left a comment
There was a problem hiding this comment.
Thanks for adding! I made some wording suggestions.
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
|
Thank you for the better wording and the typo fix @lizokm 🙇 I've committed your suggestions. |
DESCRIBE YOUR PR
Fixes getsentry/sentry-react-native#3743
This PR adds a note highlighting that source maps are not uploaded for debug mode in Expo. Note that there is a similar note in the React Native section.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES