deps: Bump next and MDX
#10511
Merged
deps: Bump next and MDX
#10511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 2.16MB ⬆️
|
chargome
approved these changes
Jun 27, 2024
lforst
commented
Jun 27, 2024
Comment on lines
-99
to
-100
| export function getAllFilesFrontMatter(folder: string = 'docs') { | ||
| const docsPath = path.join(root, folder); |
Contributor
Author
There was a problem hiding this comment.
function getAllFilesFrontMatter(folder: 'docs' | 'develop') {
let docsPath;
if (folder === 'docs') {
docsPath = path.join(root, 'docs');
} else {
docsPath = path.join(root, 'develop');
}
@a-hariti If we need to parameterize this function in the future we can do the above so that NFT continues to be able to analyze what is required for this file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A less aggressive version of #10497 bumping Next.js and the related MDX dependency.
We still need to remove the non/statically analysible path concatenation.
Bumping next caused an error to be thrown in the changelog about caching dynamic
header()calls which is not allowed - makes sense I think and even seems like a security vulnerability tbh.