deps: Bump next and related dependencies #10497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 1.19MB ⬆️
|
added 2 commits
June 26, 2024 10:11
Contributor
Author
|
From 180MB
to 15MB
|
chargome
reviewed
Jun 26, 2024
| "sidecar": "yarn spotlight-sidecar", | ||
| "test": "jest" | ||
| "test": "jest", | ||
| "build-trace": "npx next@canary internal turbo-trace-server .next/trace" |
Member
|
Fixes #10491 |
a-hariti
reviewed
Jun 26, 2024
| return frontMatter; | ||
| } | ||
|
|
||
| export function getAllFilesFrontMatter(folder: string = 'docs') { |
Collaborator
There was a problem hiding this comment.
this folder shouldn't be hardcoded as we need to pass it as a parameter for developer docs for example later on
Contributor
Author
There was a problem hiding this comment.
Right now it doesn't need to be. We can add it back if needed. We shouldn't add code for the mere possibility of needing it.
Collaborator
There was a problem hiding this comment.
I just mentioned it since this is deleting something that was already there, but I see what you mean
oioki
approved these changes
Jun 26, 2024
This was referenced Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bumping next, Vercel's NFT logic seems to have changed and we were pulling in weird additional files like
.git/objectsand webpack caches. We identified that this was due tomdx.tsusingprocess.cwd()and path concatenations which was confusing NFT, making it think pretty much everything in the root of the repo was needed to run the app. This caused us to be over the 300 MB limit for AWS lambdas.Entails:
src/mdx.tsfileFixes #10491