Skip to content

Fix: maxRequestBodySize should be never by default when using the FailedRequestClientAdapter directly #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Fix: maxRequestBodySize should be never by default when using the FailedRequestClientAdapter directly #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dceff98
Fix: maxRequestBodySize should be never by default when using the Fai…
marandaneto Jan 17, 2022
e0751c2
pr id
marandaneto Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Unreleased

* Fix: `maxRequestBodySize` should be `never` by default when using the FailedRequestClientAdapter directly (#701)

# 6.3.0-beta.2

* Feat: Improve configuration options of `SentryNavigatorObserver` (#684)
Expand Down
2 changes: 1 addition & 1 deletion dart/lib/src/http_client/failed_request_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ import 'sentry_http_client.dart';
/// ```
class FailedRequestClient extends BaseClient {
FailedRequestClient({
this.maxRequestBodySize = MaxRequestBodySize.small,
this.maxRequestBodySize = MaxRequestBodySize.never,
this.failedRequestStatusCodes = const [],
this.captureFailedRequests = true,
this.sendDefaultPii = false,
Expand Down
2 changes: 1 addition & 1 deletion dio/lib/src/failed_request_client_adapter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class FailedRequestClientAdapter extends HttpClientAdapter {
// ignore: public_member_api_docs
FailedRequestClientAdapter({
required HttpClientAdapter client,
this.maxRequestBodySize = MaxRequestBodySize.small,
this.maxRequestBodySize = MaxRequestBodySize.never,
this.failedRequestStatusCodes = const [],
this.captureFailedRequests = true,
this.sendDefaultPii = false,
Expand Down