Skip to content

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jan 17, 2022

📜 Description

Fix: maxRequestBodySize should be never by default when using the FailedRequestClientAdapter directly

💡 Motivation and Context

Not considered a breaking change because people don't use the FailedRequest adapter/client directly but rather the higher level SentryHttp client/adapter.

💚 How did you test it?

Tests don't fail because we're always passing the optional parameter in tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #701 (e0751c2) into main (aea8b40) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #701   +/-   ##
=======================================
  Coverage   90.61%   90.61%           
=======================================
  Files         103      103           
  Lines        3259     3259           
=======================================
  Hits         2953     2953           
  Misses        306      306           
Impacted Files Coverage Δ
...art/lib/src/http_client/failed_request_client.dart 93.75% <ø> (ø)
dio/lib/src/failed_request_client_adapter.dart 91.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea8b40...e0751c2. Read the comment docs.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 11b55fb into main Jan 18, 2022
@marandaneto marandaneto deleted the fix/maxRequestBodySize-never branch January 18, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants