Skip to content

[v9] Set sentry-native backend to crashpad by default and breakpad for windows arm64 #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 18, 2025
Merged

[v9] Set sentry-native backend to crashpad by default and breakpad for windows arm64 #2791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e464e65
set backend to crashpad by default and breakpad for windows
buenaflor Mar 13, 2025
5a705f1
use strequal
buenaflor Mar 13, 2025
a15a595
Update sentry-native.cmake
buenaflor Mar 13, 2025
10a9532
update
buenaflor Mar 13, 2025
7897bb1
remove message
buenaflor Mar 13, 2025
521acf3
change default native backend to crashpad in native test ffi
buenaflor Mar 13, 2025
b0860e8
update CHANGELOG
buenaflor Mar 14, 2025
a6d128c
Merge branch 'main' into native-backend
buenaflor Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- Set sentry-native backend to `crashpad` by default and `breakpad` for Windows ARM64 ([#2791](https://github.com/getsentry/sentry-dart/pull/2791))
- Setting the `SENTRY_NATIVE_BACKEND` environment variable will override the defaults.
- Move replay and privacy from experimental to options ([#2755](https://github.com/getsentry/sentry-dart/pull/2755))
- Remove renderer from `flutter_context` ([#2751](https://github.com/getsentry/sentry-dart/pull/2751))
- Cleanup platform mocking ([#2730](https://github.com/getsentry/sentry-dart/pull/2730))
Expand Down
7 changes: 2 additions & 5 deletions flutter/sentry-native/sentry-native.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,8 @@ message(STATUS "Fetching Sentry native version: ${SENTRY_NATIVE_version} from ${
set(SENTRY_SDK_NAME "sentry.native.flutter" CACHE STRING "The SDK name to report when sending events." FORCE)
set(SENTRY_BUILD_SHARED_LIBS ON CACHE BOOL "Build shared libraries (.dll/.so) instead of static ones (.lib/.a)" FORCE)

# Note: the backend is also set in linux/CMakeLists.txt and windows/CMakeLists.txt. This overwrites those if user sets an env var.
if("$ENV{SENTRY_NATIVE_BACKEND}" STREQUAL "")
# Until sentry-dart v9, we disable native backend by default.
set(SENTRY_BACKEND "none" CACHE STRING "The sentry backend responsible for reporting crashes" FORCE)
else()
if(NOT "$ENV{SENTRY_NATIVE_BACKEND}" STREQUAL "")
# If environment variable is set, it takes highest precedence
set(SENTRY_BACKEND $ENV{SENTRY_NATIVE_BACKEND} CACHE STRING "The sentry backend responsible for reporting crashes" FORCE)
endif()

Expand Down
3 changes: 1 addition & 2 deletions flutter/test/sentry_native/sentry_native_test_ffi.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ import '../mocks.mocks.dart';
enum NativeBackend { default_, crashpad, breakpad, inproc, none }

extension on NativeBackend {
// TODO change default to crashpad in v9
NativeBackend get actualValue =>
this == NativeBackend.default_ ? NativeBackend.none : this;
this == NativeBackend.default_ ? NativeBackend.crashpad : this;
}

// NOTE: Don't run/debug this main(), it likely won't work.
Expand Down
Loading