Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Mar 13, 2025

📜 Description

Change default backends for windows & linux

  • Default values are in the windows & linux cmakelists -> crashpad for linux & windows and breakpad for windows arm64
  • Backends set by env var take precedence so users can change them

💡 Motivation and Context

Closes #2641

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (98f7055) to head (a6d128c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2791      +/-   ##
==========================================
+ Coverage   88.60%   89.73%   +1.13%     
==========================================
  Files         263       91     -172     
  Lines        8766     2953    -5813     
==========================================
- Hits         7767     2650    -5117     
+ Misses        999      303     -696     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buenaflor
Copy link
Contributor Author

cc @JoshuaMoelans for visibility

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 457.57 ms 567.10 ms 109.53 ms
Size 6.44 MiB 7.56 MiB 1.12 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
68677de 364.41 ms 415.61 ms 51.20 ms
8e133ad 360.08 ms 402.82 ms 42.74 ms
9a5040f 490.15 ms 563.98 ms 73.83 ms
6aab859 306.27 ms 377.92 ms 71.65 ms
752e1cb 472.85 ms 511.60 ms 38.76 ms
2e1e4ae 413.34 ms 509.24 ms 95.90 ms
0db91cc 327.85 ms 387.31 ms 59.46 ms
84bc635 395.57 ms 464.23 ms 68.66 ms
134c9f8 301.40 ms 352.65 ms 51.26 ms
c328ffc 394.35 ms 480.94 ms 86.59 ms

App size

Revision Plain With Sentry Diff
68677de 6.06 MiB 7.10 MiB 1.04 MiB
8e133ad 6.06 MiB 7.03 MiB 990.29 KiB
9a5040f 6.46 MiB 7.48 MiB 1.01 MiB
6aab859 6.15 MiB 7.13 MiB 999.97 KiB
752e1cb 6.49 MiB 7.57 MiB 1.08 MiB
2e1e4ae 6.35 MiB 7.42 MiB 1.06 MiB
0db91cc 5.94 MiB 6.95 MiB 1.01 MiB
84bc635 6.34 MiB 7.28 MiB 968.41 KiB
134c9f8 5.94 MiB 6.95 MiB 1.01 MiB
c328ffc 6.35 MiB 7.42 MiB 1.07 MiB

Previous results on branch: native-backend

Startup times

Revision Plain With Sentry Diff
5a705f1 511.57 ms 563.77 ms 52.20 ms

App size

Revision Plain With Sentry Diff
5a705f1 6.44 MiB 7.56 MiB 1.12 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1253.15 ms 1280.47 ms 27.32 ms
Size 8.43 MiB 9.98 MiB 1.55 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
abfcdb5 1230.87 ms 1244.94 ms 14.06 ms
4d046e0 1243.08 ms 1255.98 ms 12.90 ms
0ceb89c 1252.02 ms 1271.78 ms 19.75 ms
f4cc744 1274.57 ms 1290.79 ms 16.22 ms
c73ab67 1267.73 ms 1279.36 ms 11.63 ms
dd25e43 1261.59 ms 1275.81 ms 14.22 ms
2e93bab 1237.08 ms 1258.41 ms 21.33 ms
ee0ca56 1236.44 ms 1258.89 ms 22.45 ms
bd75526 1252.62 ms 1287.00 ms 34.38 ms
178baee 1230.61 ms 1249.94 ms 19.33 ms

App size

Revision Plain With Sentry Diff
abfcdb5 8.33 MiB 9.64 MiB 1.31 MiB
4d046e0 8.42 MiB 9.83 MiB 1.40 MiB
0ceb89c 8.15 MiB 9.12 MiB 989.78 KiB
f4cc744 8.16 MiB 9.16 MiB 1.01 MiB
c73ab67 8.29 MiB 9.36 MiB 1.07 MiB
dd25e43 8.42 MiB 9.87 MiB 1.44 MiB
2e93bab 8.38 MiB 9.73 MiB 1.36 MiB
ee0ca56 8.32 MiB 9.52 MiB 1.20 MiB
bd75526 8.38 MiB 9.76 MiB 1.39 MiB
178baee 8.34 MiB 9.67 MiB 1.33 MiB

Previous results on branch: native-backend

Startup times

Revision Plain With Sentry Diff
5a705f1 1274.02 ms 1285.68 ms 11.66 ms

App size

Revision Plain With Sentry Diff
5a705f1 8.43 MiB 9.98 MiB 1.55 MiB

@buenaflor buenaflor marked this pull request as ready for review March 14, 2025 10:16
@buenaflor buenaflor requested a review from vaind March 14, 2025 10:17
@buenaflor buenaflor changed the title [v9] Set sentry-native backend to crashpad by default and breakpad for windows [v9] Set sentry-native backend to crashpad by default and breakpad for windows arm64 Mar 18, 2025
@buenaflor buenaflor merged commit 4f8df07 into main Mar 18, 2025
57 of 58 checks passed
@buenaflor buenaflor deleted the native-backend branch March 18, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v9]: Change SENTRY_NATIVE_BACKEND behavior if not set

3 participants