Skip to content

Conversation

@denrase
Copy link
Collaborator

@denrase denrase commented Feb 25, 2025

📜 Description

Remove renderer from flutter_context

💡 Motivation and Context

Closes #2712

💚 How did you test it?

CI

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (b06e562) to head (cd489a7).
Report is 1 commits behind head on v9.

Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2751      +/-   ##
==========================================
+ Coverage   88.45%   89.72%   +1.27%     
==========================================
  Files         262       91     -171     
  Lines        8750     2950    -5800     
==========================================
- Hits         7740     2647    -5093     
+ Misses       1010      303     -707     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denrase denrase marked this pull request as ready for review February 25, 2025 12:37
Copy link
Contributor

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@denrase denrase merged commit 63f825f into v9 Mar 3, 2025
59 of 60 checks passed
@denrase denrase deleted the v9-feat/remove-renderer-from-flutter-context branch March 3, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants