fix: navigation breadcrumb with missing `to` crashes native #2720

vaind · 2025-02-16T18:33:19Z

📜 Description

fixes #2719
fixes #2721

💡 Motivation and Context

💚 How did you test it?

manually by setting the navigation breadcrumb data.to field to null in the RouteObserverBreadcrumb

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

codecov · 2025-02-16T18:34:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (a7de7ef) to head (29fcd77).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2720      +/-   ##
==========================================
+ Coverage   88.99%   92.15%   +3.16%     
==========================================
  Files         263       91     -172     
  Lines        8921     2946    -5975     
==========================================
- Hits         7939     2715    -5224     
+ Misses        982      231     -751

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2025-02-16T18:56:42Z

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1261.94 ms	1279.81 ms	17.87 ms
Size	8.42 MiB	9.91 MiB	1.49 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`affcf07`	1240.61 ms	1266.49 ms	25.88 ms
`ca7f531`	1242.51 ms	1282.61 ms	40.10 ms
`b56b25c`	1243.67 ms	1265.38 ms	21.70 ms
`0db91cc`	1267.63 ms	1279.69 ms	12.06 ms
`25e9b59`	1289.76 ms	1295.27 ms	5.51 ms
`ab99a31`	1247.24 ms	1280.60 ms	33.35 ms
`519423f`	1240.80 ms	1260.88 ms	20.08 ms
`1c926c2`	1246.82 ms	1263.15 ms	16.33 ms
`8a7f528`	1232.57 ms	1249.82 ms	17.24 ms
`8bac8ba`	1261.53 ms	1279.67 ms	18.14 ms

App size

Revision	Plain	With Sentry	Diff
`affcf07`	8.38 MiB	9.70 MiB	1.33 MiB
`ca7f531`	8.32 MiB	9.38 MiB	1.06 MiB
`b56b25c`	8.42 MiB	9.91 MiB	1.49 MiB
`0db91cc`	8.15 MiB	9.15 MiB	1018.56 KiB
`25e9b59`	8.16 MiB	9.15 MiB	1021.15 KiB
`ab99a31`	8.38 MiB	9.78 MiB	1.41 MiB
`519423f`	8.10 MiB	9.16 MiB	1.06 MiB
`1c926c2`	8.42 MiB	9.89 MiB	1.47 MiB
`8a7f528`	8.10 MiB	9.16 MiB	1.06 MiB
`8bac8ba`	8.42 MiB	9.89 MiB	1.47 MiB

Previous results on branch: fix/replay-failure-navigation-breadcrumb

Startup times

Revision	Plain	With Sentry	Diff
`2e476b8`	1245.51 ms	1273.67 ms	28.16 ms

App size

Revision	Plain	With Sentry	Diff
`2e476b8`	8.42 MiB	9.91 MiB	1.49 MiB

github-actions · 2025-02-16T18:58:15Z

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	536.36 ms	547.47 ms	11.11 ms
Size	6.46 MiB	7.48 MiB	1.02 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`6d317ea`	303.46 ms	356.06 ms	52.60 ms
`9e7630d`	449.43 ms	475.82 ms	26.39 ms
`e2d89fc`	323.84 ms	376.23 ms	52.39 ms
`7c7c64f`	442.35 ms	492.79 ms	50.44 ms
`b44db8f`	307.77 ms	366.41 ms	58.64 ms
`b8562d0`	362.31 ms	437.27 ms	74.96 ms
`408bdab`	360.18 ms	434.92 ms	74.74 ms
`be173fa`	375.94 ms	458.36 ms	82.42 ms
`7f2b01d`	304.94 ms	345.71 ms	40.78 ms
`a43c400`	492.55 ms	558.31 ms	65.76 ms

App size

Revision	Plain	With Sentry	Diff
`6d317ea`	5.94 MiB	6.92 MiB	1001.74 KiB
`9e7630d`	6.49 MiB	7.56 MiB	1.07 MiB
`e2d89fc`	6.06 MiB	7.03 MiB	989.37 KiB
`7c7c64f`	6.49 MiB	7.57 MiB	1.08 MiB
`b44db8f`	6.16 MiB	7.14 MiB	1003.72 KiB
`b8562d0`	6.35 MiB	7.33 MiB	1005.53 KiB
`408bdab`	6.27 MiB	7.20 MiB	959.07 KiB
`be173fa`	6.35 MiB	7.33 MiB	1005.54 KiB
`7f2b01d`	5.94 MiB	6.95 MiB	1.01 MiB
`a43c400`	6.46 MiB	7.48 MiB	1.03 MiB

Previous results on branch: fix/replay-failure-navigation-breadcrumb

Startup times

Revision	Plain	With Sentry	Diff
`2e476b8`	468.54 ms	536.55 ms	68.01 ms

App size

Revision	Plain	With Sentry	Diff
`2e476b8`	6.46 MiB	7.48 MiB	1.02 MiB

buenaflor

👍

* update Android dependency to 7.22.0 (#2705) * fix: navigation breadcrumb with missing to crashes native (#2720) * release: 8.13.1 --------- Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]>

* update Android dependency to 7.22.0 (#2705) * fix: navigation breadcrumb with missing to crashes native (#2720) * release: 8.13.1 * update changelog * fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736) * fix * regenerate mocks * update CHANGELOG * update test * update * fix test * release: 8.13.2 --------- Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]>

* update Android dependency to 7.22.0 (#2705) * fix: navigation breadcrumb with missing to crashes native (#2720) * release: 8.13.1 * update changelog * fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736) * fix * regenerate mocks * update CHANGELOG * update test * update * fix test * release: 8.13.2 * chore(deps): update Android SDK to v7.22.1 (#2785) * update android dep * update changelog * update CHANGELOG * release: 8.13.3 * update CHANGELOG --------- Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]>

* update Android dependency to 7.22.0 (#2705) * fix: navigation breadcrumb with missing to crashes native (#2720) * release: 8.13.1 * update changelog * fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736) * fix * regenerate mocks * update CHANGELOG * update test * update * fix test * release: 8.13.2 * Use global ruby for `pod install` in min version test (#2783) * chore(deps): update Cocoa SDK to v8.46.0 (#2772) * chore: update flutter/scripts/update-cocoa.sh to 8.46.0 * Update CHANGELOG.md --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: Giancarlo Buenaflor <[email protected]> * Bind root screen transaction to scope (#2756) * chore(deps): update Android SDK to v7.22.1 (#2785) * update android dep * update changelog * update CHANGELOG * release: 8.13.3 * update CHANGELOG * Prepare `8.14.0` changelog (#2787) * update CHANGELOG * update * Update CHANGELOG.md * Update CHANGELOG.md * release: 8.14.0 --------- Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: Denis Andrašec <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub <[email protected]> Co-authored-by: getsentry-bot <[email protected]>

fix: navigation breadcrumb with missing to crashes native

2e476b8

vaind force-pushed the fix/replay-failure-navigation-breadcrumb branch from a4e9e7c to 2e476b8 Compare February 16, 2025 18:42

chore: changelog

b710064

vaind marked this pull request as ready for review February 18, 2025 10:13

vaind requested review from buenaflor, krystofwoldrich and stefanosiano as code owners February 18, 2025 10:13

Merge branch 'main' into fix/replay-failure-navigation-breadcrumb

29fcd77

buenaflor approved these changes Feb 18, 2025

View reviewed changes

vaind merged commit 67a5716 into main Feb 18, 2025
60 of 61 checks passed

vaind deleted the fix/replay-failure-navigation-breadcrumb branch February 18, 2025 21:56

buenaflor added a commit that referenced this pull request Feb 19, 2025

fix: navigation breadcrumb with missing to crashes native (#2720)

220db54

romtsn mentioned this pull request Feb 19, 2025

fix(session-replay): Do not crash if navigation breadcrumb has no destination getsentry/sentry-java#4185

Merged

7 tasks

romtsn mentioned this pull request Mar 18, 2025

Android Replays Missing & Frozen Screens getsentry/sentry-react-native#4659

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: navigation breadcrumb with missing `to` crashes native #2720

fix: navigation breadcrumb with missing `to` crashes native #2720

Uh oh!

vaind commented Feb 16, 2025 •

edited

Loading

Uh oh!

codecov bot commented Feb 16, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 16, 2025 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: fix/replay-failure-navigation-breadcrumb

Startup times

App size

Uh oh!

github-actions bot commented Feb 16, 2025 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: fix/replay-failure-navigation-breadcrumb

Startup times

App size

Uh oh!

buenaflor left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix: navigation breadcrumb with missing to crashes native #2720

fix: navigation breadcrumb with missing to crashes native #2720

Uh oh!

Conversation

vaind commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

codecov bot commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: fix/replay-failure-navigation-breadcrumb

Startup times

App size

Uh oh!

github-actions bot commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: fix/replay-failure-navigation-breadcrumb

Startup times

App size

Uh oh!

buenaflor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: navigation breadcrumb with missing `to` crashes native #2720

fix: navigation breadcrumb with missing `to` crashes native #2720

vaind commented Feb 16, 2025 •

edited

Loading

codecov bot commented Feb 16, 2025 •

edited

Loading

github-actions bot commented Feb 16, 2025 •

edited

Loading

github-actions bot commented Feb 16, 2025 •

edited

Loading