Skip to content

fix(session-replay): Do not crash if navigation breadcrumb has no destination #4185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2025
Merged

fix(session-replay): Do not crash if navigation breadcrumb has no destination #4185

merged 3 commits into from
Feb 25, 2025

Conversation

@romtsn
Copy link
Member

@romtsn romtsn commented Feb 19, 2025

📜 Description

  • Added a 5minute hard limit for a replay segment to not generate huge videos and potentially consume many device resources
  • Fix crash when a navigation breadcrumb has no destination

💡 Motivation and Context

See getsentry/sentry-dart#2720

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 401.06 ms 433.94 ms 32.88 ms
Size 1.58 MiB 2.21 MiB 641.65 KiB

Previous results on branch: rz/fix/session-replay-improvements

Startup times

Revision Plain With Sentry Diff
652f795 361.98 ms 408.85 ms 46.88 ms

App size

Revision Plain With Sentry Diff
652f795 1.58 MiB 2.21 MiB 641.08 KiB

stefanosiano
stefanosiano approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I'd just add a mention of the max duration in the changelog

@romtsn romtsn enabled auto-merge (squash) February 25, 2025 14:18
@romtsn romtsn merged commit 7d08e30 into main Feb 25, 2025
31 of 33 checks passed
@romtsn romtsn deleted the rz/fix/session-replay-improvements branch February 25, 2025 14:25
@romtsn romtsn mentioned this pull request Mar 18, 2025
Closed
romtsn added a commit that referenced this pull request Mar 19, 2025
@romtsn
fix(session-replay): Do not crash if navigation breadcrumb has no des…
c48ad34 
…tination (#4185)

* Do not crash if navigation breadcrumb has not destination

* Changelog
romtsn added a commit that referenced this pull request Mar 19, 2025
@romtsn
fix(session-replay): Do not crash if navigation breadcrumb has no des…
2360d0a 
…tination (#4185)

* Do not crash if navigation breadcrumb has not destination

* Changelog
@romtsn romtsn mentioned this pull request Mar 19, 2025
Merged
romtsn added a commit that referenced this pull request Mar 20, 2025
@romtsn
fix(session-replay): Do not crash if navigation breadcrumb has no des…
bd16527 
…tination (#4185) (#4269)

* fix(session-replay):  Do not crash if navigation breadcrumb has no destination (#4185)

* Do not crash if navigation breadcrumb has not destination

* Changelog

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanosiano stefanosiano stefanosiano approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

@lcian lcian Awaiting requested review from lcian lcian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romtsn @stefanosiano