Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Extract minimum required coverage by Jacoco plugin. #541

Merged
Parent: sentry-java v-next
merged 1 commit into from
Sep 4, 2020
Merged

Extract minimum required coverage by Jacoco plugin. #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions buildSrc/src/main/java/Config.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import java.math.BigDecimal

object Config {
val kotlinVersion = "1.3.72"
val kotlinStdLib = "stdlib-jdk8"
Expand Down Expand Up @@ -72,6 +74,10 @@ object Config {
}

object QualityPlugins {
object Jacoco {
val version = "0.8.5"
val minimumCoverage = BigDecimal.valueOf(0.6)
}
val jacocoVersion = "0.8.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'll remove it in Spring PR.

val spotless = "com.diffplug.spotless"
val spotlessVersion = "5.1.0"
Expand Down
5 changes: 2 additions & 3 deletions sentry-core/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ configure<SourceSetContainer> {
}

jacoco {
toolVersion = Config.QualityPlugins.jacocoVersion
toolVersion = Config.QualityPlugins.Jacoco.version
}

tasks.jacocoTestReport {
Expand All @@ -56,8 +56,7 @@ tasks.jacocoTestReport {
tasks {
jacocoTestCoverageVerification {
violationRules {
// TODO: Raise the minimum to a sensible value.
rule { limit { minimum = BigDecimal.valueOf(0.1) } }
rule { limit { minimum = Config.QualityPlugins.Jacoco.minimumCoverage } }
}
}
check {
Expand Down
4 changes: 2 additions & 2 deletions sentry-log4j2/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ configure<SourceSetContainer> {
}

jacoco {
toolVersion = Config.QualityPlugins.jacocoVersion
toolVersion = Config.QualityPlugins.Jacoco.version
}

tasks.jacocoTestReport {
Expand All @@ -57,7 +57,7 @@ tasks.jacocoTestReport {
tasks {
jacocoTestCoverageVerification {
violationRules {
rule { limit { minimum = BigDecimal.valueOf(0.6) } }
rule { limit { minimum = Config.QualityPlugins.Jacoco.minimumCoverage } }
}
}
check {
Expand Down
4 changes: 2 additions & 2 deletions sentry-logback/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ configure<SourceSetContainer> {
}

jacoco {
toolVersion = Config.QualityPlugins.jacocoVersion
toolVersion = Config.QualityPlugins.Jacoco.version
}

tasks.jacocoTestReport {
Expand All @@ -56,7 +56,7 @@ tasks.jacocoTestReport {
tasks {
jacocoTestCoverageVerification {
violationRules {
rule { limit { minimum = BigDecimal.valueOf(0.6) } }
rule { limit { minimum = Config.QualityPlugins.Jacoco.minimumCoverage } }
}
}
check {
Expand Down
4 changes: 2 additions & 2 deletions sentry-spring-boot-starter/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ configure<SourceSetContainer> {
}

jacoco {
toolVersion = Config.QualityPlugins.jacocoVersion
toolVersion = Config.QualityPlugins.Jacoco.version
}

tasks.jacocoTestReport {
Expand All @@ -76,7 +76,7 @@ tasks.jacocoTestReport {
tasks {
jacocoTestCoverageVerification {
violationRules {
rule { limit { minimum = BigDecimal.valueOf(0.6) } }
rule { limit { minimum = Config.QualityPlugins.Jacoco.minimumCoverage } }
}
}
check {
Expand Down