This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Extract minimum required coverage by Jacoco plugin. #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
bruno-garcia
reviewed
Sep 4, 2020
| val version = "0.8.5" | ||
| val minimumCoverage = BigDecimal.valueOf(0.6) | ||
| } | ||
| val jacocoVersion = "0.8.5" |
There was a problem hiding this comment.
Good catch. I'll remove it in Spring PR.
|
Thanks for this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Move minimum required coverage to
Configclass and use same value (0.6) in all modules.💡 Motivation and Context
Reduce duplication and possibility of having different quality gates in different modules.
💚 How did you test it?
📝 Checklist
🔮 Next steps