feat: Read debug IDs from debugId field #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
added a commit
to getsentry/symbolic
that referenced
this pull request
Nov 6, 2024
Companion PR to getsentry/rust-sourcemap#97. This adjusts `discover_sourcemap_embedded_debug_id` so that it finds debug IDs at both `"debug_id"` and `"debugId"`.
lforst
approved these changes
Nov 6, 2024
3 tasks
loewenheim
added a commit
to getsentry/symbolic
that referenced
this pull request
Nov 6, 2024
Companion PR to getsentry/rust-sourcemap#97. This adjusts `discover_sourcemap_embedded_debug_id` so that it finds debug IDs at both `"debug_id"` and `"debugId"`.
loewenheim
added a commit
to getsentry/sentry-cli
that referenced
this pull request
Nov 7, 2024
This is accomplished by updating `symbolic` and `rust-sourcemap`. See getsentry/symbolic#874 and getsentry/rust-sourcemap#97. Closes #2220.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially implements #96. The debug id will still be serialized as
"debug_id", but can now additionally be read from"debugId".