Skip to content

Commit 262f625

Browse files
authored
feat: Read debug IDs from debugId field in sourcemaps (#2222)
This is accomplished by updating `symbolic` and `rust-sourcemap`. See getsentry/symbolic#874 and getsentry/rust-sourcemap#97. Closes #2220.
1 parent 03523ba commit 262f625

File tree

6 files changed

+97
-16
lines changed

6 files changed

+97
-16
lines changed

Cargo.lock

Lines changed: 61 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ sentry = { version = "0.34.0", default-features = false, features = [
6868
serde = { version = "1.0.152", features = ["derive"] }
6969
serde_json = "1.0.93"
7070
sha1_smol = { version = "1.0.0", features = ["serde"] }
71-
sourcemap = { version = "7.0.1", features = ["ram_bundle"] }
72-
symbolic = { version = "12.12.0", features = ["debuginfo-serde", "il2cpp"] }
71+
sourcemap = { version = "9.0.1", features = ["ram_bundle"] }
72+
symbolic = { version = "12.12.1", features = ["debuginfo-serde", "il2cpp"] }
7373
thiserror = "1.0.38"
7474
url = "2.3.1"
7575
username = "0.2.0"
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
```
2+
$ sentry-cli sourcemaps upload tests/integration/_fixtures/upload_debugid_alias
3+
? success
4+
> Found 2 files
5+
> Analyzing 2 sources
6+
> Rewriting sources
7+
> Adding source map references
8+
> Bundled 2 files for upload
9+
> Bundle ID: [..]-[..]-[..]-[..]-[..]
10+
> Uploaded files to Sentry
11+
> File upload complete (processing pending on server)
12+
> Organization: wat-org
13+
> Project: wat-project
14+
> Release: None
15+
> Dist: None
16+
> Upload type: artifact bundle
17+
18+
Source Map Upload Report
19+
Scripts
20+
~/server/chunks/1.js (sourcemap at 1.js.map, debug id 2297b93d-928d-421e-8910-127c786382da)
21+
Source Maps
22+
~/server/chunks/1.js.map (debug id 2297b93d-928d-421e-8910-127c786382da)
23+

tests/integration/_fixtures/upload_debugid_alias/server/chunks/1.js

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/integration/_fixtures/upload_debugid_alias/server/chunks/1.js.map

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/integration/sourcemaps/upload.rs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,14 @@ fn command_sourcemaps_upload_some_debugids_v2() {
135135
assert_endpoints(&upload_endpoints);
136136
}
137137

138+
/// Tests that debug IDs can be found under the "debugId" field in sourcemaps.
139+
#[test]
140+
fn command_sourcemaps_upload_debugid_alias() {
141+
let upload_endpoints = mock_common_upload_endpoints(ServerBehavior::Modern, Default::default());
142+
register_test("sourcemaps/sourcemaps-upload-debugid-alias.trycmd");
143+
assert_endpoints(&upload_endpoints);
144+
}
145+
138146
#[test]
139147
fn command_sourcemaps_upload_no_debugids() {
140148
let _upload_endpoints =

0 commit comments

Comments
 (0)