Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@cosnomi
Copy link
Contributor

@cosnomi cosnomi commented Jan 17, 2020

概要

docs/static-folderの和訳です

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました(推奨)
  • Allow edits from maintainers にチェックを入れました。

@cosnomi cosnomi marked this pull request as ready for review January 17, 2020 15:46
@cosnomi cosnomi assigned cosnomi and unassigned cosnomi Jan 17, 2020
@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 18, 2020
uetchy
uetchy previously approved these changes Jan 20, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned status: ready to merge A pull request that can be merged once CI is green and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 20, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつかSuggestしたので確認おねがいします

@cosnomi
Copy link
Contributor Author

cosnomi commented Jan 22, 2020

@Naturalclar ありがとうございます。applyしたものをcommitしました!

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます!
textlintの指摘箇所の修正おねがいします:pray:

@Naturalclar Naturalclar added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned status: ready to merge A pull request that can be merged once CI is green labels Jan 22, 2020
@cosnomi
Copy link
Contributor Author

cosnomi commented Jan 22, 2020

@Naturalclar lintのエラー見落としてました、すみません。修正しました!

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます!

@Naturalclar Naturalclar added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 22, 2020
@cosnomi cosnomi requested a review from uetchy January 22, 2020 14:57
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy merged commit d27ade8 into gatsbyjs:master Jan 23, 2020
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants