-
Notifications
You must be signed in to change notification settings - Fork 113
Contributing/how-to-open-a-pull-request #206
Contributing/how-to-open-a-pull-request #206
Conversation
Naturalclar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HelloTakako PR ありがとうございます! いくつか Lint のエラーが出ているので、その修正対応をお願いしたいです:bow:
Files changed から Lint の指摘箇所を確認できます。
44e6154 to
093299b
Compare
|
@Naturalclar |
Naturalclar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!いくつか追加で Suggest したのでご確認お願いします。
|
@HelloTakako Read this comment as well: #202 (comment) |
Naturalclar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HelloTakako ありがとうございます!:+1::+1::+1:
|
@imbsky Thank you for letting me know about "Commit suggestion" or "Add suggestion to batch", I will use those next time. |
概要
contributing/how-to-open-a-pull-requestを翻訳しましたので、レビューをよろしくお願いいたします。
チェックリスト
textlintを使って校正を行いました。Allow edits from maintainersにチェックを入れました。補足
Ref: #196