Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@HelloTakako
Copy link
Contributor

@HelloTakako HelloTakako commented Feb 25, 2020

概要

contributing/how-to-open-a-pull-requestを翻訳しましたので、レビューをよろしくお願いいたします。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #196

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HelloTakako PR ありがとうございます! いくつか Lint のエラーが出ているので、その修正対応をお願いしたいです:bow:
Files changed から Lint の指摘箇所を確認できます。

@Naturalclar Naturalclar added the status: awaiting author response A pull request that is awaiting author's response label Feb 25, 2020
@HelloTakako HelloTakako force-pushed the contributing/how-to-open-a-pull-request branch from 44e6154 to 093299b Compare February 25, 2020 05:15
@HelloTakako
Copy link
Contributor Author

@Naturalclar
ごめんなさい、自身のフォークレポジトリを最新にしておらず、校正用のファイルを更新していませんでした。
修正したので、お手数ですがご確認をお願いします。

@HelloTakako HelloTakako added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 25, 2020
@smorimoto smorimoto added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 27, 2020
@HelloTakako HelloTakako added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 27, 2020
@HelloTakako HelloTakako self-assigned this Feb 27, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!いくつか追加で Suggest したのでご確認お願いします。

@HelloTakako HelloTakako added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 27, 2020
@smorimoto smorimoto added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 28, 2020
@smorimoto
Copy link
Contributor

@HelloTakako Read this comment as well: #202 (comment)

@HelloTakako HelloTakako reopened this Feb 28, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HelloTakako ありがとうございます!:+1::+1::+1:

@Naturalclar Naturalclar added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 28, 2020
@smorimoto smorimoto merged commit ec98d70 into gatsbyjs:master Feb 28, 2020
@HelloTakako
Copy link
Contributor Author

@imbsky Thank you for letting me know about "Commit suggestion" or "Add suggestion to batch", I will use those next time.
@Naturalclar 色々不慣れでごめんなさい、レビュー&Suggestありがとうございます。

@HelloTakako HelloTakako deleted the contributing/how-to-open-a-pull-request branch March 1, 2020 04:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants