This repository was archived by the owner on Jan 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 113
Transrate contributing/how-to-file-an-issue
#197
Merged
smorimoto
merged 12 commits into
gatsbyjs:master
from
kawamataryo:contributing/how-to-file-an-issue
Feb 23, 2020
Merged
Transrate contributing/how-to-file-an-issue
#197
smorimoto
merged 12 commits into
gatsbyjs:master
from
kawamataryo:contributing/how-to-file-an-issue
Feb 23, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7337ad5 to
fc78620
Compare
kawamataryo
commented
Feb 22, 2020
c5358da to
d72c9af
Compare
kawamataryo
commented
Feb 22, 2020
d72c9af to
d1db328
Compare
Naturalclar
reviewed
Feb 22, 2020
Naturalclar
reviewed
Feb 22, 2020
Naturalclar
reviewed
Feb 22, 2020
Naturalclar
reviewed
Feb 22, 2020
Naturalclar
reviewed
Feb 22, 2020
Naturalclar
reviewed
Feb 22, 2020
Naturalclar
reviewed
Feb 22, 2020
Naturalclar
reviewed
Feb 22, 2020
Naturalclar
reviewed
Feb 22, 2020
Naturalclar
suggested changes
Feb 22, 2020
Contributor
Naturalclar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR ありがとうございます!いくつか Suggest したのでご確認お願いします。
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Contributor
Author
|
迅速なレビューありがとうございます!!! 一点だけ質問のコメントしたのでご確認お願いします。:pray: |
c0337d5 to
8847b4e
Compare
Naturalclar
reviewed
Feb 23, 2020
38 tasks
Co-Authored-By: Jesse Katsumata <[email protected]>
Naturalclar
approved these changes
Feb 23, 2020
Contributor
Naturalclar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!LGTM
smorimoto
approved these changes
Feb 23, 2020
|
Holy buckets, @kawamataryo — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Contributor
|
Thanks @kawamataryo for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
contributing/how-to-file-an-issueを翻訳してみました。よろしくお願いします。
チェックリスト
textlintを使って校正を行いました。Allow edits from maintainersにチェックを入れました。補足
こちらの気になっている部分は事前にコメントしました。
何分初めての試みなので修正点多々あると思うのですが、よろしくお願いします:pray:
Ref: #1