Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

translate contributing/why_contributeto_gatsby #18

Merged
merged 3 commits into from
Jan 15, 2020
Merged

translate contributing/why_contributeto_gatsby #18

merged 3 commits into from
Jan 15, 2020

Conversation

@sanposhiho
Copy link
Contributor

@sanposhiho sanposhiho commented Jan 14, 2020

No description provided.

@sanposhiho
Copy link
Contributor Author

sanposhiho commented Jan 14, 2020

sweet swag dealなどの転移先と翻訳を合わせた方がいいと感じた部分はそのまま英語で残してありますが、どうでしょうか

@sanposhiho sanposhiho force-pushed the translate_why_contributeto_gatsby branch from 95668c8 to bf0cbac Compare January 14, 2020 19:48
@gatsbybot gatsbybot mentioned this pull request Jan 15, 2020
Closed
Naturalclar
Naturalclar suggested changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanposhiho
PR ありがとうございます！
読みやすさの向上のため、日本語から英語に切り替わるとき、及び英語から日本語に切り替わるときにスペースを入れて頂いてもよろしいでしょうか 🙏

例：

  • ○ こんにちは Gatsby こんにちは。
  • x こんにちはGatsbyこんにちは。

(今後、この辺はlint-ruleで整備するつもりです。)

@smorimoto
Copy link
Contributor

smorimoto commented Jan 15, 2020

JTF日本語標準スタイルガイドでは確かスペースを入れない決まりになっていて、どっちが良いのかは議論の余地があるかもしれない。(既に決まっているのであればそれに寄せるので良いとは思ってる。)

文字間のスペース

原則として、全角文字と半角文字の間にスペースを入れません。

◯ ✕
JTF標準 JTF 標準

@uetchy
Copy link
Contributor

uetchy commented Jan 15, 2020 

"3.1.1.全角文字と半角文字の間": false, // 全角文字と半角文字の間にスペースを入れる

元々スペースを入れるルールでしたが、スペースが入っているかどうかをチェックしていませんでした。#21 によって今後はチェックされるようになります。

uetchy
uetchy reviewed Jan 15, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体的にとてもクオリティが高いです👍

@sanposhiho sanposhiho force-pushed the translate_why_contributeto_gatsby branch from f443835 to edaf91d Compare January 15, 2020 02:45
Naturalclar
Naturalclar reviewed Jan 15, 2020
View reviewed changes
uetchy
uetchy approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

docs/contributing/why-contribute-to-gatsby.md
- **スキルの向上** Gatsby に Issue を立てたり Pull Request を投げたりすることで必然的にあなたはどのような仕組みでプロジェクトが動作しているのかを学ぶことができます。また、質問をしたり情報を集めたりソースコードを自分で掘り下げることによっても学びが深まるでしょう。もし、何か協力して行いたい事があるのであれば、 Gatsby が無料で提供する [pair programming sessions](/contributing/pair-programming/) を使用できます。

- **Getting free swag!** By participating in the repo on GitHub, you can become eligible for free swag that the Gatsby team offers as a way to say thank you. With 5 contributions, you can advance to a second level with even more swag options! Learn more about this [sweet swag deal](/contributing/contributor-swag/).
- **無料の景品** GitHub のリポジトリーに貢献することで Gatsby チームからの感謝の気持ちとして景品を無料で受け取ることができます。また、5 回目以降の貢献であれば、より豪華な景品を受け取ることができるようになります！これについて詳しくはこちらの [sweet swag deal](/contributing/contributor-swag/) をご覧ください。
Copy link
Contributor

@uetchy uetchy Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet swag dealはそのままにしても良いと思います。

Naturalclar
Naturalclar approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！LGTM

@Naturalclar Naturalclar merged commit bae34d5 into gatsbyjs:master Jan 15, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 15, 2020

Holy buckets, @sanposhiho — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@sanposhiho sanposhiho deleted the translate_why_contributeto_gatsby branch January 15, 2020 23:21
@Naturalclar Naturalclar mentioned this pull request Apr 16, 2020
Closed
38 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hirotaka hirotaka Awaiting requested review from hirotaka

2 more reviewers

@uetchy uetchy uetchy approved these changes

@Naturalclar Naturalclar Naturalclar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sanposhiho @smorimoto @uetchy @Naturalclar