This repository was archived by the owner on Jan 20, 2025. It is now read-only.
translate docs/css-libraries-and-frameworks #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harapeko
requested review from
Naturalclar,
hirotaka,
smorimoto and
uetchy
as code owners
harapeko
commented
Feb 13, 2020
| Gatsby プロジェクトでは多くの CSS スタイルライブラリやフレームワークを使用できます。 | ||
|
|
||
| These libraries are not full-on approaches to styling, and generally work no matter which styling approach you've chosen for your website. They require installing third-party libraries, often with the help of Gatsby community plugins. | ||
| これらのライブラリは[スタイリング手法](/docs/styling/)には関係しません。また、一般的にはどのスタイリング手法をウェブサイトに選択したとしても機能します。 |
Contributor
Author
There was a problem hiding this comment.
how?
スタイリング手法(styling approach) にリンクを設けました。
why?
このリンクがあることで スタイリング手法(styling approach) が本ページ及び、GuideListのことを指しているのではなく、リンク先の大別3種の事を指していることを明らかにできると思ったからです。
逆にこのリンクがないと本ページのことを指していると誤解を招く可能性があり、必要と判断しました。
Contributor
There was a problem hiding this comment.
@harapeko 提案ありがとうございます！良い変更だと思います。
本リポジトリはあくまで原文の翻訳という立ち位置なので、 まずは Gatsby 本家のドキュメントに変更を提案できると良いと思います:bow:
Contributor
Author
There was a problem hiding this comment.
提案してきました！gatsbyjs/gatsby#21491
本家Contributeの導きをありがとうございます👍
5 tasks
smorimoto
added
the
status: awaiting review
Naturalclar
reviewed
Feb 15, 2020
| These libraries are not full-on approaches to styling, and generally work no matter which styling approach you've chosen for your website. They require installing third-party libraries, often with the help of Gatsby community plugins. | ||
| これらのライブラリは[スタイリング手法](/docs/styling/)には関係しません。また、一般的にはどのスタイリング手法をウェブサイトに選択したとしても機能します。 | ||
|
|
||
| 大抵の場合は Gatsby コミュニティプラグインの助けを借りてサードパーティライブラリをインストールする必要があります。 |
Contributor
There was a problem hiding this comment.
改行を原文と合わせていただけると助かります:bow:
原文に変更があったときにDiffを見やすくするためです。
Naturalclar
suggested changes
Feb 15, 2020
Contributor
Naturalclar
left a comment
Naturalclar
left a comment
There was a problem hiding this comment.
一つSuggestしたので確認お願いします:pray:
uetchy
previously approved these changes
Feb 15, 2020
uetchy
added
status: awaiting author response
why? Easy diff with original. branch docs/css-libraries-and-frameworks
Contributor
Author
|
@Naturalclar Suggestionを取り込みました！ |
Naturalclar
added
status: awaiting more approval
smorimoto
approved these changes
Feb 16, 2020
Contributor
|
Thanks @harapeko for your contribution! |
uetchy
removed
the
status: awaiting more approval
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
https://www.gatsbyjs.org/docs/css-libraries-and-frameworks の翻訳です
チェックリスト
textlintを使って校正を行いました。Allow edits from maintainersにチェックを入れました。補足
Ref: #1