This repository was archived by the owner on Jan 20, 2025. It is now read-only.
translate docs/creating-global-styles #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harapeko
requested review from
Naturalclar,
hirotaka,
smorimoto and
uetchy
as code owners
harapeko
force-pushed
the
docs/creating-global-styles
branch
from
7c36946 to
a108c15
Compare
harapeko
force-pushed
the
docs/creating-global-styles
branch
from
a108c15 to
e775b19
Compare
harapeko
commented
Feb 13, 2020
| --- | ||
|
|
||
| Creating global styles for your Gatsby site depends on your styling approach, so we've moved the instructions to the relevant guides: | ||
| Gatsby サイトでのグローバルスタイル作成は、開発者の[スタイリング手法](/docs/styling)に依るので、それぞれの説明を関連するガイドに編纂しました： |
Contributor
Author
There was a problem hiding this comment.
how?
スタイリング手法(styling approach) にリンクを設けました。
why?
- 具体的に説明しているページがあるため
- translate docs/css-libraries-and-frameworks #175 (review) でも
スタイリング手法(styling approach)にリンクを設けたため
不要？
リンク先は本ページと類似しており、少しおせっかいなリンクかもしれません。
リンクを取り除くべきであればSuggestionをお願い致します。
Contributor
There was a problem hiding this comment.
@harapeko コメントありがとうございます！
このリポジトリは基本的にGatsbyの原文に沿うものでありたいと思っています。
リンクを付けること自体は良いと思うので、ぜひGatsby本家のドキュメントに Contribute してみましょう:sparkles:
Contributor
Author
There was a problem hiding this comment.
提案してきました！gatsbyjs/gatsby#21491
本家Contributeの導きをありがとうございます👍
Contributor
Author
There was a problem hiding this comment.
本家への提案、リンク追加がマージされました✌
smorimoto
added
the
status: awaiting review
uetchy
approved these changes
Feb 15, 2020
Naturalclar
approved these changes
Feb 15, 2020
uetchy
removed
the
status: awaiting review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
https://www.gatsbyjs.org/docs/creating-global-styles/ の翻訳です
チェックリスト
textlintを使って校正を行いました。Allow edits from maintainersにチェックを入れました。補足
Ref: #1