Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@yukisato
Copy link
Contributor

@yukisato yukisato commented Jan 26, 2020

概要

本文を翻訳しましたので、レビューをお願いします。

※スタック・オーバーフローについて参照先を日本語版サイトに変更していますが、
Gatsby タグがある件数が0件なので、このまま日本語版にしたままにするか英語版にするかは
レビュアーさんの方でご判断いただけますでしょうか。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #1

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 26, 2020
uetchy
uetchy previously approved these changes Jan 26, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

uetchy
uetchy previously approved these changes Jan 26, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 26, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yukisato PR ありがとうございます!いくつか Suggest したのでご確認お願いします。

@Naturalclar Naturalclar added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 26, 2020
yukisato and others added 2 commits January 26, 2020 13:12
@yukisato
Copy link
Contributor Author

レビューありがとうございます。
ご提案された変更について反映しましたので、ご確認をお願いします。

@yukisato yukisato requested a review from Naturalclar January 26, 2020 21:27
@yukisato yukisato added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 26, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます!

@Naturalclar Naturalclar added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 27, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy merged commit eb7d0df into gatsbyjs:master Jan 27, 2020
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 27, 2020
@yukisato yukisato deleted the contributing/community branch January 28, 2020 00:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants