Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Contributing/community contributions #127

Merged
merged 5 commits into from
Jan 27, 2020
Merged

Contributing/community contributions #127

merged 5 commits into from
Jan 27, 2020

Conversation

@yukisato
Copy link
Contributor

@yukisato yukisato commented Jan 25, 2020 •
edited
Loading

概要

文章全体の翻訳を行いました。
レビューをお願いします！

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #1

@gatsbybot gatsbybot mentioned this pull request Jan 25, 2020
Closed
uetchy
uetchy previously approved these changes Jan 25, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます👍

@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 25, 2020
@yukisato
Copy link
Contributor Author

yukisato commented Jan 25, 2020

レビューありがとうございます。
変更を反映させていただきました！

@yukisato yukisato removed the status: awaiting author response A pull request that is awaiting author's response label Jan 25, 2020
uetchy
uetchy previously approved these changes Jan 26, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 26, 2020
Naturalclar
Naturalclar reviewed Jan 26, 2020
View reviewed changes
Naturalclar
Naturalclar suggested changes Jan 26, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ありがとうございます！良い翻訳と感じました。細かいスペースの統一部分だけ Suggest したので確認おねがいします。

@Naturalclar Naturalclar added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 26, 2020
@yukisato
Copy link
Contributor Author

yukisato commented Jan 26, 2020

レビューありがとうございました！
Suggestionを反映しましたので、ご確認をお願いします。

@yukisato yukisato added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 26, 2020
@yukisato yukisato requested a review from Naturalclar January 26, 2020 21:26
Naturalclar
Naturalclar approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Naturalclar Naturalclar removed the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 27, 2020
@Naturalclar Naturalclar added the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 27, 2020
uetchy
uetchy approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@uetchy uetchy merged commit de4e54a into gatsbyjs:master Jan 27, 2020
@yukisato yukisato deleted the contributing/community-contributions branch January 28, 2020 00:30
@yukisato yukisato removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 28, 2020
@Naturalclar Naturalclar mentioned this pull request Apr 16, 2020
Closed
38 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hirotaka hirotaka Awaiting requested review from hirotaka

@smorimoto smorimoto Awaiting requested review from smorimoto

2 more reviewers

@uetchy uetchy uetchy approved these changes

@Naturalclar Naturalclar Naturalclar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yukisato @uetchy @Naturalclar