Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@ryo4004
Copy link
Contributor

@ryo4004 ryo4004 commented Jan 24, 2020

概要

docs/add-404-page を翻訳しました。
レビューよろしくお願いいたします。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

Ref: #1

@ryo4004 ryo4004 changed the title Translate docs/add 404 page Translate docs/add-404-page Jan 24, 2020
@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 24, 2020
uetchy
uetchy previously approved these changes Jan 24, 2020
@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 24, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良い訳だと思います!一箇所違和感があったので、Suggest しました。ご確認お願いします。

@Naturalclar Naturalclar added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 25, 2020
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@uetchy uetchy added status: ready to merge A pull request that can be merged once CI is green and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 25, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Naturalclar Naturalclar merged commit c11d7bc into gatsbyjs:master Jan 25, 2020
@ryo4004 ryo4004 deleted the translate-docs/add-404-page branch January 25, 2020 04:34
@uetchy uetchy removed the status: ready to merge A pull request that can be merged once CI is green label Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants