WIP: Gradle 5 and Java 11 support #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the wrapper, but does not build correctly yet due to the way Kotlin compiler libraries are resolved. To address this issue, the previous mechanism of copying the dependent libraries into a local folder from which they are included has to be updated. Since depending on JAR files is non-ideal, a better solution would be to find the (correctly packaged) libraries on a Maven repository and include them.
Updates the Kotlin version of the language server to 1.3.3x
Updates the Gradle-TeamCity plugin to 0.19 for Gradle 5 support.
Adds the kotlin-scripting-compiler to the classpath since CliScriptDefinitionProvider has been moved to this package.
Updates the script (and script dependencies) provider to the most recent API. The issue that no declarators can be found for SCRIPT declarations persists however (this can be verified using the EditFunctionTest).
Owner
Author
|
Unfortunately, support for Kotlin scripts is broken due to some breaking API changes in the script declaration resolver. For more details, see the commit message on 4df20d4. |
This was referenced May 22, 2019
Closed
Closed
|
Is this still true for kotlin |
This was referenced Jul 17, 2019
Gradle 5.6 introduces interpolated version strings in the 'plugins' block which make it easier to maintain the current Kotlin version in a single place.
Register a ScriptingCompilerConfigurationComponentRegistrar as described in https://youtrack.jetbrains.com/issue/KT-30679. In the LanguageServerTestFixture, output the memory usage after each test and format log messages to a single line.
Remove some unused dependencies.
|
I see this was merged, how do I build the server under 11? |
Owner
Author
|
@casret Just as before, using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks support for Gradle 5 and Java 11.