feat(forge): optimize compilation through preprocessing and caching #10010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
reviewed
Mar 5, 2025
zerosnacks
reviewed
Mar 5, 2025
|
added working on adding depending on the edited file the results are mixed in impact but always more favorable with test caching enabled |
|
For
The diff (with / without test caching) being limited to: Alternatively:
Can also just be a side effect of how the codebase is set up with very deep hierarchies |
Yeah, most probably many mocks aka contracts under test that extend contracts under src, like for example contract BatchTestProcedures is Test, DeployUtils, FfiUtils, DefaultMarketInputwhere You can check all the files marked as mock in cache file |
they also have |
|
Let me know if there's sth I can help with on the aave side. I suspect the problem is though that we essentially deploy the whole protocol + periphery on every test, which is not trivial to change. |
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse and
yash-atreya
as code owners
|
Tested on Solady and Euler's EVC - no issues, added the benchmarks |
8 tasks
grandizzy
force-pushed
the
issue-9863
branch
2 times, most recently
from
103404d to
def0113
Compare
mattsse
pushed a commit
to foundry-rs/compilers
that referenced
this pull request
Apr 7, 2025
Implements a preprocessor allowing us to skip recompiling tests on non-interface source file changes. See the companion Foundry PR foundry-rs/foundry#10010 for benchmarks and more details. Supersedes #198: - uses solar AST instead solang-parser to compute interface representation - uses solar HIR instead of solc AST to find bytecode dependencies - handles more edge cases, like deploying with salt/value Closes #197. ### TODO - [x] use solar HIR (deps to review and include paradigmxyz/solar#210) - [x] unit tests - [x] opt-in caching changes - [x] autodetect mocks - [x] figure out how to parse when building from different dir - [x] additional testing (tested with uniswap v4-core and simpler projects) ### Depends on - [x] merge solar PR (paradigmxyz/solar#210) - [x] solar release --------- Co-authored-by: Arsenii Kulikov <[email protected]> Co-authored-by: zerosnacks <[email protected]> Co-authored-by: DaniPopes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
dynamic_test_linkingto avoid unnecessary test compilation. Disabled by default, can be used asforge build --dynamic-test-linkingTODO
Lock.lock();at PoolManager.sol#L107amountOut < minAmountOutat PSM3.sol#L125if (assets < 0)at MorphoBundler.sol#L106require(assets != 0, ErrorsLib.ZERO_ASSETS)at Morpho.sol#L424if (cliffTime < 0)at SablierLockup.sol#L480_setOwner(newOwner)at Ownable.sol#L182SET_MAX_ELEMENTSto11at Set.sol#L7Solution
PR Checklist