Dynamic test linking default enabled

Author: grandizzy

crates/cli/src/opts/build/core.rs

@@ -34,10 +34,10 @@ pub struct BuildOpts {
     #[serde(skip)]
     pub no_cache: bool,
 
-    /// Enable preprocessed cache for tests
-    #[arg(long, conflicts_with = "no_cache")]
+    /// Disable dynamic test linking.
+    #[arg(long)]
     #[serde(skip)]
-    pub dynamic_test_linking: bool,
+    pub no_dynamic_test_linking: bool,
 
     /// Set pre-linked libraries.
     #[arg(long, help_heading = "Linker options", env = "DAPP_LIBRARIES")]
@@ -250,8 +250,8 @@ impl Provider for BuildOpts {
             dict.insert("cache".to_string(), false.into());
         }
 
-        if self.dynamic_test_linking || self.no_cache {
-            dict.insert("dynamic_test_linking".to_string(), true.into());
+        if self.no_dynamic_test_linking || self.no_cache {
+            dict.insert("dynamic_test_linking".to_string(), false.into());
         }
 
         if self.build_info {

crates/config/src/lib.rs

@@ -2281,7 +2281,7 @@ impl Default for Config {
             out: "out".into(),
             libs: vec!["lib".into()],
             cache: true,
-            dynamic_test_linking: false,
+            dynamic_test_linking: true,
             cache_path: "cache".into(),
             broadcast: "broadcast".into(),
             snapshots: "snapshots".into(),

crates/forge/tests/cli/config.rs

@@ -42,7 +42,7 @@ forgetest!(can_extract_config_values, |prj, cmd| {
         out: "out-test".into(),
         libs: vec!["lib-test".into()],
         cache: true,
-        dynamic_test_linking: false,
+        dynamic_test_linking: true,
         cache_path: "test-cache".into(),
         snapshots: "snapshots".into(),
         gas_snapshot_check: false,
@@ -972,7 +972,7 @@ remappings = ["forge-std/=lib/forge-std/src/"]
 auto_detect_remappings = true
 libraries = []
 cache = true
-dynamic_test_linking = false
+dynamic_test_linking = true
 cache_path = "cache"
 snapshots = "snapshots"
 gas_snapshot_check = false
@@ -1130,7 +1130,7 @@ exclude = []
   "auto_detect_remappings": true,
   "libraries": [],
   "cache": true,
-  "dynamic_test_linking": false,
+  "dynamic_test_linking": true,
   "cache_path": "cache",
   "snapshots": "snapshots",
   "gas_snapshot_check": false,

crates/forge/tests/cli/test_optimizer.rs

@@ -2,9 +2,6 @@
 
 // Test cache is invalidated when `forge build` if optimize test option toggled.
 forgetest_init!(toggle_invalidate_cache_on_build, |prj, cmd| {
-    prj.update_config(|config| {
-        config.dynamic_test_linking = true;
-    });
     // All files are built with optimized tests.
     cmd.args(["build"]).with_no_redact().assert_success().stdout_eq(str![[r#"
 ...
@@ -35,9 +32,6 @@ Compiling 22 files with [..]
 
 // Test cache is invalidated when `forge test` if optimize test option toggled.
 forgetest_init!(toggle_invalidate_cache_on_test, |prj, cmd| {
-    prj.update_config(|config| {
-        config.dynamic_test_linking = true;
-    });
     // All files are built with optimized tests.
     cmd.args(["test"]).with_no_redact().assert_success().stdout_eq(str![[r#"
 ...
@@ -74,9 +68,6 @@ Compiling 20 files with [..]
 //     └── Counter.t.sol
 forgetest_init!(preprocess_contract_with_no_interface, |prj, cmd| {
     prj.wipe_contracts();
-    prj.update_config(|config| {
-        config.dynamic_test_linking = true;
-    });
 
     prj.add_source(
         "Counter.sol",
@@ -201,9 +192,6 @@ Compiling 1 files with [..]
 //     └── Counter.t.sol
 forgetest_init!(preprocess_contract_with_interface, |prj, cmd| {
     prj.wipe_contracts();
-    prj.update_config(|config| {
-        config.dynamic_test_linking = true;
-    });
 
     prj.add_source(
         "interface/CounterIf.sol",
@@ -341,9 +329,6 @@ Compiling 1 files with [..]
 //         └── CounterMock.sol
 forgetest_init!(preprocess_mock_without_inheritance, |prj, cmd| {
     prj.wipe_contracts();
-    prj.update_config(|config| {
-        config.dynamic_test_linking = true;
-    });
 
     prj.add_source(
         "Counter.sol",
@@ -498,9 +483,6 @@ Compiling 2 files with [..]
 //        └── CounterMock.sol
 forgetest_init!(preprocess_mock_with_inheritance, |prj, cmd| {
     prj.wipe_contracts();
-    prj.update_config(|config| {
-        config.dynamic_test_linking = true;
-    });
 
     prj.add_source(
         "Counter.sol",
@@ -637,9 +619,6 @@ Compiling 2 files with [..]
 //        └── CounterMock.sol
 forgetest_init!(preprocess_mock_to_non_mock, |prj, cmd| {
     prj.wipe_contracts();
-    prj.update_config(|config| {
-        config.dynamic_test_linking = true;
-    });
 
     prj.add_source(
         "Counter.sol",
@@ -752,9 +731,6 @@ Compiling 2 files with [..]
 // └── Counter.t.sol
 forgetest_init!(preprocess_multiple_contracts_with_constructors, |prj, cmd| {
     prj.wipe_contracts();
-    prj.update_config(|config| {
-        config.dynamic_test_linking = true;
-    });
 
     prj.add_source(
         "Counter.sol",
@@ -1019,9 +995,6 @@ Compiling 1 files with [..]
 // Test preprocessing contracts with payable constructor, value and salt named args.
 forgetest_init!(preprocess_contracts_with_payable_constructor_and_salt, |prj, cmd| {
     prj.wipe_contracts();
-    prj.update_config(|config| {
-        config.dynamic_test_linking = true;
-    });
 
     prj.add_source(
         "Counter.sol",