Fix compilation error in ifort #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note this fixed #520, and using an earlier kludged version of my own that worked with ifort, ifort let me verify two bugs in fpm and is very helpful in helping ensure fpm is as standard-conforming as possible going into the future. Can anyone else take a look? |
LKedward
approved these changes
Jul 28, 2021
Member
LKedward
left a comment
LKedward
left a comment
There was a problem hiding this comment.
Thanks both! Being able to use ifort will be incredibly useful for developing and debugging fpm. LGTM
Closed
Member
Author
|
With two approvals I'll go ahead and merge later today. Next thing to discuss is whether we want to start testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intel Fortran (
ifort) is choking on the TOML proxy module in fpm, due to overloading theget_valueinterface in the proxy with an fpm specific data type. For some reason this alters the signature of thetoml_tabledata type and causes a compilation error.