Skip to content

Conversation

@urbanjost
Copy link
Contributor

The help text was being truncated for the command syntax sections and the number of unused variables that has accumulated was obscuring significant warnings and some trailing whitespace that keeps coming up in PRs was trimmed. Should not change logic at all but removes around fifty warning messages and fixes the trimmed messages.

@LKedward LKedward self-requested a review July 19, 2021 06:30
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@urbanjost
Copy link
Contributor Author

@awvwgk. A question about TOML. While I was loo king for low-hanging fruit I came across a line in the TOML code that I thought should produce a warning where it had "ptr(1:0)". Is that a trick to pass a null pointer I did not know? It produced no warning with any compiler I tried. Also, if you take this version and if you take all the USE statements that import TOML_TABLE
and import them from the TOMLF module, but leave all the others alone, it compiles with the Intel classic module (ifort) but I could not find anywhere were that should be the case (otherwise it says TOML_TABLE is imported simultaneously from two modules but does not indicate where the overlap is). By eye I went though all of it and as far as I could tell it is a compiler bug, maybe because TOML_TABLE was created by extension and the others are not. If there is anything you see that should be a separate PR, but thought I would mention it, as I find it useful to test with as many compilers as I can and if that is a bug I want to reduce it to a reproducer and get it into Intel. The only relationship to this PR is that it is handy to use multiple compilers for sweeping for items like this PR is cleaning up and I keep forgetting to ask it otherwise:>

@awvwgk
Copy link
Member

awvwgk commented Jul 19, 2021

This might be easier to explain with a patch (see #523). Probably a bug in Intel Fortran, but I gave up on reporting those.

Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@LKedward LKedward merged commit 9e26b2d into fortran-lang:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants