Remove: coarray single from default Intel flags. #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awvwgk
approved these changes
Apr 11, 2021
Member
awvwgk
left a comment
awvwgk
left a comment
There was a problem hiding this comment.
We shouldn't enable coarray support if there is no stub or shared memory implementation available. For Intel it seems we can only use it with Intel MPI, so we are better off by setting it with --flag for the time being.
everythingfunctional
approved these changes
Apr 12, 2021
Member
everythingfunctional
left a comment
everythingfunctional
left a comment
There was a problem hiding this comment.
I waffled back and forth on this one. If it's causing more problems than it's solving, I'm good with removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just had an unexpected error with the most recent fpm version and then noticed that #431 added
-coarray=singleback into the default Intel flags (removed in #300). This PR removes it again.