Skip to content

Conversation

@everythingfunctional
Copy link
Member

I've tested both profiles (debug and release) on each platform (Windows, MacOS, and Linux) for both Intel compilers (ifort and ifx) and none of them report an problems with flags now.

Note that ifx is not available on MacOS currently, so that is not included in the set of available compilers.

Also Note: none of the Intel compilers were able to compile fpm. ifort gives the following error on all three platforms:

./src/fpm/manifest/build.f90: error #6405: The same named entity from different modules and/or program units cannot be referenced.   [TOML_TABLE]

ifx hits an ICE on Windows, and gives the following error on Linux:

build/dependencies/M_CLI2/src/M_CLI2.f90(1322): error #5533: Feature found on this line is not yet supported in ifx 
            args=[character(len=imax) :: args,current_argument]
----------------------------------------------^

but those are issues for another day.

Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@urbanjost urbanjost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently changed hardware and could not test all the combinations. I thought other issues would arise with loading and library names after the compile but what I could test had no issues. Either way these compiler flags needed changed and It worked on my laptop. Another step forward.
Thanks. I approve.

@everythingfunctional
Copy link
Member Author

Thanks for the review guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants